Input: Make macro chords work properly #12285
Conversation
There was a problem hiding this comment.
Thank you for submitting a contribution to PCSX2
As this is your first pull request, please be aware of the contributing guidelines.
Additionally, as per recent changes in GitHub Actions, your pull request will need to be approved by a maintainer before GitHub Actions can run against it. You can find more information about this change here.
Please be patient until this happens. In the meantime if you'd like to confirm the builds are passing, you have the option of opening a PR on your own fork, just make sure your fork's master branch is up to date!
|
Can you change the commit name to have a proper prefix? |
Is this possible to reasonably accomplish using github, or I need to nuke my fork for this? |
|
You want to clone your branch locally and do |
|
Maybe I misunderstood the PR but it doesn't seem to fix #8192 for me, as a test I set Shift+V as Circle and pressing either Shift OR V is sending a Circle input. edit: forgot to mention but I'm on Windows 10 if it matters. |
|
tested it on windows 10 and works for me! nice update, mgs3 is even more playable now |
pcsx2-record.mp4Just made a video, I'm binding Circle to Shift & V and you can see that it still acts as OR instead of AND (I show the version at the end just to show that I'm running a version with this PR merged). But again, maybe I misunderstood the PR, idk 🤷 But it doesn't fix #8192 in my case. |
This pull request only implements the fix for macros, not for bindings that are triggered by a combination of multiple keys. Use macros for now until someone makes the fix for everything |
|
OK I see, thanks for the clarification 👍 |
---------------------------------------------------- pcsx2.mk v2.3.188 # Version: Commits on Mar 01, 2025 ---------------------------------------------------- - [Input: Make macro chords work properly](PCSX2/pcsx2#12285) ------------------------------------------------------------------------------------ rpcs3.mk 8e6272bfeef72b2dda239c4aced05aa88982c700 # Version: Commits on Mar 01, 2025 ------------------------------------------------------------------------------------ Qt: Fix boot failed dialog, --------------------------------------------------------------------------------------------- theforceengine.mk d3d1c8b0ece821dd50fbfa81f1538b3a6259c318 # Version: Commits on Mar 01, 2025 --------------------------------------------------------------------------------------------- * Removed ENABLE_FORCE_SCRIPT logic - scripting is here to stay. * Fixed numerous warnings., ---------------------------------------------------------------------------------------- doomretro.mk 59e6032a4c85189e02fdbd7a39762892d6b5df1f # Version: Commits on Mar 01, 2025 ---------------------------------------------------------------------------------------- Update releasenotes.md, ------------------------------------------------------------------------------------------ xash3d-fwgs.mk c76752cc5f92bacdc19b09353f74f659f147d19e # Version: Commits on Mar 01, 2025 ------------------------------------------------------------------------------------------ engine: server: validate uuid in protinfo, it's an md5 string, --------------------------------------------------------------------------------------------------- libretro-squirreljme.mk 396817f035b3f6ba32eee3a745aed46efefd960a # Version: Commits on Mar 01, 2025 --------------------------------------------------------------------------------------------------- Correct aload test.
Description of Changes
Macros don't trigger if you only press one key of a chord anymore, fixes #8192
InputAxisEventHandlerhasInputBindingKeyas an argument nowInputManager::SplitChordwas made publicSetMacroButtonStatewas changed to check if all triggers of a macro were pressed before proceeding with the inputRationale behind Changes
To make games that utilize pressure sensitive controls, like MGS3, playable on controllers that don't have it
Suggested Testing Steps
Test this on a windows system, because I don't have one