-
-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] plasma5: 5.17.5 -> 5.18.5 #84542
Conversation
nix-review output:
|
Is this getting good to go by chance? |
The gtk settings and deepin packages are broken (due to kwin update). I have spent some time on both but didn't find any easy fixes. If you want to bring this closer to being merged, feel free to take a look at those problems. I can not tell how much time I will be able to spend on this in the next days. |
The deepin packages have stagnated on upstream. For almost an year they have not been updated. Deepin Linux is working privately on a new version of their Linux distribution with substantial changes. For this reason the packaging of the Deepin Desktop Environment is dormant on nixpkgs as well, waiting new releases from upstream. For now I think you can mark both |
@ofborg eval |
I am investigating the GTK theme issue now. My first guess is that it is due to the missing dependency on |
Actually, it has nothing to do with EDIT: I have lots of messages like this in
So I guess |
Apparently I already fixed this? #40447 |
deepin was removed in #96610, please rebase. |
I fixed |
We are still affected by #96055, but I don't see that as a reason to block merging as soon as the check pass again! |
Thanks everyone who helped this happen, especially @petabyteboy ! 🎉 |
Motivation for this change
Todo list:
port patches / fix broken behaviour in these packages
fix broken packages:
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)