Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Add plasma-phone package #58370

Closed
wants to merge 2 commits into from
Closed

WIP: Add plasma-phone package #58370

wants to merge 2 commits into from

Conversation

Slabity
Copy link
Contributor

@Slabity Slabity commented Mar 26, 2019

Motivation for this change

This is a work in progress for getting plasma-mobile software working in NixOS.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Slabity Slabity requested a review from ttuegel as a code owner March 26, 2019 15:07
samueldr
samueldr reviewed Mar 26, 2019
View reviewed changes
pkgs/desktops/plasma-5/srcs.nix
src = fetchurl {
url = "https://invent.kde.org/kde/plasma-phone-components/-/archive/master/plasma-phone-components-master.tar.gz";
sha256 = "0jmw0c2pj4dmak1w49r4lwwg3c4zvgn5d3h3ihrzksh23ni7kb3b";
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Nothing to do right now, but to be done eventually before merging.)

Their invent platform is a GitLab server, fetchFromGitLab should be used to fetch their tarballs since revision tarballs, from most repo hosting systems, might eventually change as they are generated, making the sha256 unstable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would be the process of getting this on a mirror to match all the other packages in srcs.nix?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bit

Ends up using either of:

Depending of where exactly it would go (among other srcs.nix handled by that script). So basically whenever kde/plasma publishes a released source for that.

@GrahamcOfBorg GrahamcOfBorg added 6.topic: qt/kde 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 26, 2019
@Slabity
Copy link
Contributor Author

Slabity commented Mar 26, 2019

I'm currently trying to get a configuration option to enable the mobile shell. I can get it working manually by running plasmashell -p org.kde.plasma.phone (after killing the default plasmashell), but I'd like to try and match it to the current plasma-desktop as closely as possible.

If anyone has a better idea on how to do this it would be greatly appreciated.

@Slabity Slabity requested a review from infinisil as a code owner March 26, 2019 16:49
@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Mar 26, 2019
@aanderse
Copy link
Member

ping (triage)
status?

@samueldr samueldr added the 2.status: work-in-progress This PR isn't done label Jul 27, 2019
@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
Thra11
Thra11 suggested changes Sep 5, 2020
View reviewed changes
pkgs/desktops/plasma-5/srcs.nix
@@ -234,6 +234,14 @@
name = "plasma-browser-integration-5.14.5.tar.xz";
};
};
# TODO: Change to use "${mirror}" once available
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plasma-phone-components has releases in stable since 5.18, so now that #84542 is merged, you don't need to add anything to srcs.nix.

pkgs/desktops/plasma-5/plasma-phone/default.nix
let inherit (lib) getBin getLib; in

mkDerivation {
name = "plasma-phone";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The upstream project is named plasma-phone-components, not plasma-phone. We should give our package the same name unless we have a good reason not to.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 5, 2020
@Thra11
Copy link
Member

Thra11 commented Sep 5, 2020

There a few other plasma-mobile packages in stable srcs.nix now too.

@ryantm ryantm added 2.status: merge conflict This PR has merge conflicts with the target branch and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Oct 3, 2020
@ryantm ryantm marked this pull request as draft October 23, 2020 03:07
@Slabity
Copy link
Contributor Author

Slabity commented Nov 4, 2020 •
edited
Loading

Sorry to disappoint, but I'm not really able to work on this further. I will be closing this as I believe there is a much more organized 'Mobile NixOS' initiative going on:

https://mobile.nixos.org/

@Slabity Slabity closed this Nov 4, 2020
@samueldr
Copy link
Member

samueldr commented Mar 16, 2021 •
edited
Loading

Anyone following this PR, or finding this PR, and is concerned about this being dropped. I'm packaging it up. I'm also packaging up plasma mobile apps that don't already have a PR here.

I have a WIP dirty branch here:

Already in it is a couple PRs, and the changes required for Plasma Mobile to work. Though things don't exactly work out of the box. At least for the DM session. So stay tuned for a follow-up PR!

@samueldr samueldr mentioned this pull request May 1, 2021
Merged
10 tasks
@samueldr
Copy link
Member

samueldr commented May 1, 2021

So for anyone still following this PR, to help push myself into finishing this, #121345 was opened. Not really ready for reviews, but something to look at.

@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samueldr samueldr samueldr left review comments

@Thra11 Thra11 Thra11 requested changes

@ttuegel ttuegel Awaiting requested review from ttuegel

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 2.status: work-in-progress This PR isn't done 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: qt/kde 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Slabity @aanderse @Thra11 @samueldr @ryantm @GrahamcOfBorg @Janik-Haag