-
-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] plasma5: 5.17.5 -> 5.18.5 #84542
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
381667a
plasma5: 5.17.5 -> 5.18.5
6c062bf
deepin.dde-kwin, deepin.startdde: mark as broken
70fb2bb
kdecoration-viewer: remove
81b770f
kde-gtk-config: add xsettingsd input
ttuegel 69ec9ed
kde-gtk-config: set GSettings schemas path
ttuegel 66eb5c8
kdeplasma-addons: add kpurpose and qtwebengine as inputs
ttuegel 5091d35
Merge branch 'master' into feature/plasma-5-18
ttuegel 38fcee2
kinfocenter: add kirigami2 input
ttuegel cb44493
ksysguard: add libcap and libpcap inputs
ttuegel 59e5dc4
kwin: add qtquickcontrols2 and qtvirtualkeyboard inputs
ttuegel e904041
plasma-desktop: add qqc2-desktop-style input
ttuegel 78c52f7
kquickcharts: init at 5.73.0
ttuegel 6105abd
plasma-workspace: add kquickcharts and appstream-qt inputs
ttuegel 18dd58a
plasma-pa: add sound-theme-freedesktop input
ttuegel 75db15c
xdg-desktop-portal-kde: add epoxy and mesa inputs
ttuegel 24ebfb1
powerdevil: update patches
ttuegel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
WGET_ARGS=( https://download.kde.org/stable/plasma/5.17.5/ ) | ||
WGET_ARGS=( https://download.kde.org/stable/plasma/5.18.5/ ) |
21 changes: 21 additions & 0 deletions
21
pkgs/desktops/plasma-5/kde-gtk-config/0001-gsettings-schemas-path.patch
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
diff --git a/kded/gtkconfig.cpp b/kded/gtkconfig.cpp | ||
index 5303636..199c4d5 100644 | ||
--- a/kded/gtkconfig.cpp | ||
+++ b/kded/gtkconfig.cpp | ||
@@ -41,6 +41,16 @@ GtkConfig::GtkConfig(QObject *parent, const QVariantList&) : | ||
kdeglobalsConfigWatcher(KConfigWatcher::create(KSharedConfig::openConfig(QStringLiteral("kdeglobals")))), | ||
kwinConfigWatcher(KConfigWatcher::create(KSharedConfig::openConfig(QStringLiteral("kwinrc")))) | ||
{ | ||
+ // Add GSETTINGS_SCHEMAS_PATH to the front of XDG_DATA_DIRS. | ||
+ // Normally this would be done by wrapGAppsHook, but this plugin | ||
+ // (shared object) cannot be wrapped. | ||
+ QByteArray xdgdata = qgetenv("XDG_DATA_DIRS"); | ||
+ if (!xdgdata.isEmpty()) { | ||
+ xdgdata.push_front(":"); | ||
+ } | ||
+ xdgdata.push_front(QByteArray(GSETTINGS_SCHEMAS_PATH)); | ||
+ qputenv("XDG_DATA_DIRS", xdgdata); | ||
+ | ||
QDBusConnection dbus = QDBusConnection::sessionBus(); | ||
dbus.registerService(QStringLiteral("org.kde.GtkConfig")); | ||
dbus.registerObject(QStringLiteral("/GtkConfig"), this, QDBusConnection::ExportScriptableSlots); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49 changes: 0 additions & 49 deletions
49
pkgs/desktops/plasma-5/kde-gtk-config/patches/follow-symlinks.patch
This file was deleted.
Oops, something went wrong.
21 changes: 0 additions & 21 deletions
21
pkgs/desktops/plasma-5/kde-gtk-config/patches/gsettings.patch
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,17 +1,18 @@ | ||
{ | ||
mkDerivation, | ||
extra-cmake-modules, kdoctools, | ||
kconfig, kconfigwidgets, kcoreaddons, kcmutils, kdelibs4support, kio, | ||
knewstuff, kross, krunner, kservice, ksysguard, kunitconversion, ibus, | ||
plasma-framework, plasma-workspace, qtdeclarative, qtx11extras, kholidays | ||
kconfig, kconfigwidgets, kcoreaddons, kcmutils, kdelibs4support, kholidays, | ||
kio, knewstuff, kpurpose, kross, krunner, kservice, ksysguard, | ||
kunitconversion, ibus, plasma-framework, plasma-workspace, qtdeclarative, | ||
qtwebengine, qtx11extras | ||
}: | ||
|
||
mkDerivation { | ||
name = "kdeplasma-addons"; | ||
nativeBuildInputs = [ extra-cmake-modules kdoctools ]; | ||
buildInputs = [ | ||
kconfig kconfigwidgets kcoreaddons kcmutils kdelibs4support kio knewstuff | ||
kross krunner kservice ksysguard kunitconversion ibus plasma-framework | ||
plasma-workspace qtdeclarative qtx11extras kholidays | ||
kconfig kconfigwidgets kcoreaddons kcmutils kdelibs4support kholidays kio | ||
knewstuff kpurpose kross krunner kservice ksysguard kunitconversion ibus | ||
plasma-framework plasma-workspace qtdeclarative qtwebengine qtx11extras | ||
]; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,20 @@ | ||
{ | ||
mkDerivation, | ||
extra-cmake-modules, kdoctools, | ||
gconf, glib, kconfigwidgets, kcoreaddons, kdeclarative, kglobalaccel, ki18n, | ||
libcanberra-gtk3, libpulseaudio, plasma-framework, qtdeclarative, kwindowsystem | ||
kconfigwidgets, kcoreaddons, kdeclarative, kglobalaccel, ki18n, kwindowsystem, plasma-framework, | ||
qtdeclarative, | ||
gconf, glib, libcanberra-gtk3, libpulseaudio, sound-theme-freedesktop | ||
}: | ||
|
||
mkDerivation { | ||
name = "plasma-pa"; | ||
nativeBuildInputs = [ extra-cmake-modules kdoctools ]; | ||
buildInputs = [ | ||
gconf glib kconfigwidgets kcoreaddons kdeclarative kglobalaccel ki18n | ||
libcanberra-gtk3 libpulseaudio plasma-framework qtdeclarative kwindowsystem | ||
gconf glib libcanberra-gtk3 libpulseaudio sound-theme-freedesktop | ||
|
||
kconfigwidgets kcoreaddons kdeclarative kglobalaccel ki18n plasma-framework | ||
kwindowsystem | ||
|
||
qtdeclarative | ||
]; | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have we confirmed that these packages are actually not necessary? I recall, in particular, that
kde-gtk-config
was completely broken withoutfollow-symlinks.patch
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please refer to this comment on the state of gtk-config:
So no, without patches it doesn't work, but since source was 100% replaced with new code upstream, the patches won't apply and can not be easily rewritten.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The answer to your question is: No, we haven't confirmed. Quite the opposite, we have confirmed that it doesn't work without patches, which is also the reason why figuring out the new way to do this is part of the todo list in the initial comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I recall, the patches mainly affected the code for the settings menu. The code that needs to be patched has probably moved to
systemsettings
. I guess we may also need to patch thekded
module, but I can't imagine what that module is actually doing: setting the GTK theme is a matter of writing a few static files, so I don't know why we need a running daemon to do that.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more information on this new "Plasma GTKd" is available here:
https://phabricator.kde.org/D24743
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And the new settings page is added here: https://phabricator.kde.org/D26583
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the new code already follows symlinks, at least the only place where I can find something that looks similar to the code that was previously patched (plasma-desktop/kcms/style/gtkthemesmodel.cpp L. 154) uses QDir().entryList without passing QDir::NoSymlinks.