Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2025-01-17 #55396

Closed
60 tasks done
github-actions bot opened this issue Jan 17, 2025 · 18 comments
Closed
60 tasks done

Deploy Checklist: New Expensify 2025-01-17 #55396

github-actions bot opened this issue Jan 17, 2025 · 18 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Jan 17, 2025

Release Version: 9.0.87-3
Compare Changes: production...staging

This release contains changes from the following pull requests:

Internal QA:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics for this release version and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked Firebase Crashlytics for the previous release version and verified that the release did not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@izarutskaya izarutskaya added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Jan 17, 2025
@joekaufmanexpensify
Copy link
Contributor

checked off #55209

@joekaufmanexpensify
Copy link
Contributor

checked off #55223

@joekaufmanexpensify
Copy link
Contributor

checked off #55203

@neil-marcellini
Copy link
Contributor

I checked off all per diem deploy blockers and removed the labels because it's a feature behind a beta.

@jasperhuangg
Copy link
Contributor

Demoting #55416 from #55416 (comment)

@mvtglobally
Copy link

Regression is at 95% completed

Blockers
#55413
#55414
#55417
#55423

Unchecked PRs
#53895 - Pending validation on Android
#54619 - Pending validation on Android
#55150 - Pending validation on Web
#55190 - is failing with #55423
#55272 - Checking off #55272 (comment)
#55281 - Pending validation on IOS

@mvtglobally
Copy link

Regression is completed

Blockers
#55413
#55414
#55417
#55423
#55447
#55448
#55450

Unchecked PRs
#54619 - It is not possible to add bank account in Hybrid app due to the following KI's: #52199 #55318. Is it ok to check this off?
#55150 - is failing with original issue. #55150 (comment)
#55190 - is failing with #55423

@Beamanator
Copy link
Contributor

Beamanator commented Jan 20, 2025

Checked off #55448 and #55450 and marked NAB b/c "Per diem" is behind a beta

@Beamanator
Copy link
Contributor

Beamanator commented Jan 20, 2025

Checking off #55150 b/c 1 of 2 bugs were fixed, so bug still exists on prod (see my comment here)

@izarutskaya
Copy link

Checking off #55451 All environments passed

This comment has been minimized.

@Beamanator
Copy link
Contributor

Nice! Then checking off #55413 👍

@Beamanator
Copy link
Contributor

Checking off #55414 as fixed by #55451

@Beamanator
Copy link
Contributor

#54619 - It is not possible to add bank account in Hybrid app due to the following KI's: #52199 #55318. Is it ok to check this off?

Yep, seems like it - confirmed in slack here 👍

@Beamanator
Copy link
Contributor

Marking #55447 NAB b/c it's reproducible on prod hybrid app too

@Beamanator
Copy link
Contributor

Checking off #55417 as confirmed fixed by #55472

@Beamanator
Copy link
Contributor

Marking #55423 as NAB b/c it's been happening since Jan 11. That means we can also check off #55190, the last PR to be checked!

@Beamanator
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

8 participants