Per diem - Inconsistency in description formatting when submitting per diem offline and online

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue was found while executing QA for PR #54760

Version Number: 9.0.87-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #54760
Email or phone of affected tester (no customers): Mac 15.0 / Chrome
Issue reported by: Applause Internal Team
Device used: applausetester+100106kh@applause.expensifail.com
App Component: Money Requests

Action Performed:

Precondition:

• Workspace has per diem rates.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Go offline.
4. Click + > Submit expense > Per diem.
5. Select destination > Next.
6. Select time > Next.
7. Click Subrate.
8. Select a subrate.
9. Enter quantity that is larger than 1.
10. Submit the expense.
11. Go to transaction thread.
12. Note that the description field shows "20x Part Day @ €0.34".
13. Go online.

Expected Result:

The description field content should remain consistent when creating per diem expense offline and after returning online.

Actual Result:

In offline mode, the description field shows "20x Part Day @ €0.34".
After returning online, it shows "Part Day @ €0.34 x 20".

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @srikarparsi (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[vincdargento]

@MitchExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[shubham1206agra]

@Gonals, Can you look into this since the doc has a different design than what you are sending through BE? https://docs.google.com/document/d/1c6WDOJlhvODD0mRKaCHfQk_HRNmq5K7hSDHLu06Pbq8/edit?tab=t.0#bookmark=id.no4w5esni3zt

[neil-marcellini]

NAB, per diem is behind a beta

[truph01]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• In offline mode, the description field shows "20x Part Day @ €0.34".
• After returning online, it shows "Part Day @ €0.34 x 20".

What is the root cause of that problem?

• The optimistic format used in FE is different from the one used in BE:

App/src/libs/actions/IOU.ts

Line 2724 in 64ed6a5

return `${quantity}x ${rateComment} @ ${convertAmountToDisplayString(rate, currency)}`;

What changes do you think we should make in order to solve the problem?

• We should update it to:

        return `${rateComment} @ ${convertAmountToDisplayString(rate, currency)} x ${quantity}`;

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

• We should add the test case for computeDefaultPerDiemExpenseComment to make sure this function have correct format.

What alternative solutions did you explore? (Optional)

[Gonals]

I'll take this as part of the Per Diem project. We likely have to change the description in the BE

[flaviadefaria]

The current cohort do not have per diem as a feature so moving this to #expense

[melvin-bot]

@Gonals, @MitchExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@Gonals, @MitchExpensify Huh... This is 4 days overdue. Who can take care of this?

[Gonals]

Already fixed