Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS - Swiping back after enabling feature returns to features page instead of workspace list #55414

Closed
3 of 8 tasks
vincdargento opened this issue Jan 17, 2025 · 8 comments
Closed
3 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Hourly KSv2

Comments

@vincdargento
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.87-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): iPhone 15 Pro Max / iOS 18.2
Issue reported by: Applause Internal Team
Device used: applausetester+100106kh@applause.expensifail.com
App Component: Workspace Settings

Action Performed:

  1. Launch ND or hybrid app.
  2. Go to workspace settings.
  3. Go to More features.
  4. Enable any feature.
  5. After app redirects to workspace editor LHN, use device gesture to swipe back to previous page.

Expected Result:

App should return to workspace settings (production behavior).

Actual Result:

App returns to More features page.

If user returns to More features and enable many features, then user will have to swipe back many times.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

@vincdargento vincdargento added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 DeployBlockerCash This issue or pull request should block deployment labels Jan 17, 2025
Copy link

melvin-bot bot commented Jan 17, 2025

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Jan 17, 2025

Triggered auto assignment to @flodnv (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Jan 17, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jan 17, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@vincdargento
Copy link
Author

@lschurr FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@samranahm
Copy link

Offending PR: #53938. Issue resolved with revert in PR: #55451. Unable to reproduce the issue after the revert.

@melvin-bot melvin-bot bot added the Overdue label Jan 20, 2025
@Beamanator Beamanator removed the DeployBlockerCash This issue or pull request should block deployment label Jan 20, 2025
@Beamanator
Copy link
Contributor

Agreed this is working well for me now! marking NAB (probably can close this out)

@flodnv
Copy link
Contributor

flodnv commented Jan 20, 2025

Great, thanks @samranahm @Beamanator ! 🙇

@flodnv flodnv closed this as completed Jan 20, 2025
@melvin-bot melvin-bot bot removed the Overdue label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants