Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use invoiceTransferBankAccountID to determine default badge for a payment method on Invoices page #54619

Merged
merged 5 commits into from
Jan 16, 2025

Conversation

Shahidullah-Muffakir
Copy link
Contributor

@Shahidullah-Muffakir Shahidullah-Muffakir commented Dec 27, 2024

Explanation of Change

Default Badge on Invoices: Show it only if invoiceTransferBankAccountID exists for that policy.

Set Default Payment Method: When adding a new payment method from invoices, send policyID and source = 'invoice' to AddPersonalBankAccount to make it default for that policy.

Fixed Issues

$ #53693
PROPOSAL: #53693 (comment)

Tests

Test1: (Invoices page)

  1. Add the First Bank Account:

    • Go to the Invoices page of a workspace.
    • Click Add Bank Account.
    • select Wells Fargo Bank (Checking).
    • Enter valid credentials (e.g., user_good / pass_good) and complete the process.
    • Verify: The newly added bank account is not marked as the default, and the "Make default payment method" option is not visible.
  2. Add a Second Bank Account:

    • Follow the same steps to add a second account, selecting Chase Bank (Saving).
    • Confirm:
      • The "Make default payment method" option appears in the three-dot menu for the first bank account.
      • The default badge is shown on the second account (Chase Bank Saving).
  3. Verify "Make default payment method" is Available with One Account:

    • In the Invoices page, delete the default account.
    • Confirm: The "Make default payment method" button is still visible for the remaining payment method.
  4. Verify Defaults are Independent Between Pages:

    1. Set the first bank account (Wells Fargo - Checking) as default on the Invoices page.
    2. Go to the Wallet page and check the default payment method.
    3. Confirm: The default payment method on the Wallet page is the second added payment method (Chase Bank - Saving).

Test2: (Wallet page)

  1. Add the First Bank Account:

    • Go to Settings > Wallet, click Add Bank Account > Personal Bank Account.
    • select Wells Fargo Bank (Checking).
    • Enter valid credentials (e.g., user_good / pass_good) and complete the process.
    • Verify: The newly added bank account is not marked as the default, and the "Make default payment method" option is not visible.
  2. Add a Second Bank Account:

    • Follow the same steps to add a second account, selecting Chase Bank (Saving).
    • Confirm:
      • The "Make default payment method" option appears in the three-dot menu for the first bank account.
      • The default badge is shown on the second account (Chase Bank Saving).
  3. Verify Defaults are Independent Between Pages:

    1. Go to the Invoices page and check the default payment method.
    2. Confirm: Both payment methods should have the "Make default payment method" option available and no payment method should have the default badge.
  • Verify that no errors appear in the JS console

Offline tests

Internet connection needed.

QA Steps

Test1: (Invoices page)

  1. Add the First Bank Account:

    • Go to the Invoices page of a workspace.
    • Click Add Bank Account.
    • select Wells Fargo Bank (Checking).
    • Enter valid credentials (e.g., user_good / pass_good) and complete the process.
    • Verify: The newly added bank account is not marked as the default, and the "Make default payment method" option is not visible.
  2. Add a Second Bank Account:

    • Follow the same steps to add a second account, selecting Chase Bank (Saving).
    • Confirm:
      • The "Make default payment method" option appears in the three-dot menu for the first bank account.
      • The default badge is shown on the second account (Chase Bank Saving).
  3. Verify "Make default payment method" is Available with One Account:

    • In the Invoices page, delete the default account.
    • Confirm: The "Make default payment method" button is still visible for the remaining payment method.
  4. Verify Defaults are Independent Between Pages:

    1. Set the first bank account (Wells Fargo - Checking) as default on the Invoices page.
    2. Go to the Wallet page and check the default payment method.
    3. Confirm: The default payment method on the Wallet page is the second added payment method (Chase Bank - Saving).

Test2: (Wallet page)

  1. Add the First Bank Account:

    • Go to Settings > Wallet, click Add Bank Account > Personal Bank Account.
    • select Wells Fargo Bank (Checking).
    • Enter valid credentials (e.g., user_good / pass_good) and complete the process.
    • Verify: The newly added bank account is not marked as the default, and the "Make default payment method" option is not visible.
  2. Add a Second Bank Account:

    • Follow the same steps to add a second account, selecting Chase Bank (Saving).
    • Confirm:
      • The "Make default payment method" option appears in the three-dot menu for the first bank account.
      • The default badge is shown on the second account (Chase Bank Saving).
  3. Verify Defaults are Independent Between Pages:

    1. Go to the Invoices page and check the default payment method.
    2. Confirm: Both payment methods should have the "Make default payment method" option available and no payment method should have the default badge.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Screen.20Recording.202025-01-16.20at.202.mp4
Android: mWeb Chrome
android.20web-2.mp4
iOS: Native
ios.20native-3.mp4
iOS: mWeb Safari
ios.20safari-3.mp4
MacOS: Chrome / Safari
macosafari.mp4
MacOS: Desktop
Screen.20Recording.202025-01-14.20at.203.mp4

@Shahidullah-Muffakir Shahidullah-Muffakir requested a review from a team as a code owner December 27, 2024 13:18
@melvin-bot melvin-bot bot requested a review from jjcoffee December 27, 2024 13:18
Copy link

melvin-bot bot commented Dec 27, 2024

@jjcoffee Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team December 27, 2024 13:18
@jjcoffee
Copy link
Contributor

BUG: If the first bank account hasn't been manually marked as default, adding a second bank account shows the default label against it on the Invoices page, but the Wallet page shows a different default bank account (the first one).

@Shahidullah-Muffakir
Copy link
Contributor Author

@jjcoffee PR is ready for your review. There are some ESLint errors, but they are not related to the changes made in this PR. Should we address them here, or handle them separately?

@jjcoffee
Copy link
Contributor

jjcoffee commented Jan 14, 2025

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
android-app-2025-01-14_15.55.34.mp4
Android: mWeb Chrome
android-chrome-2025-01-14_16.14.28.mp4
iOS: Native
ios-app-2025-01-14_16.53.58.mp4
iOS: mWeb Safari
ios-safari-2025-01-14_16.58.40.mp4
MacOS: Chrome / Safari
desktop-chrome-2025-01-14_15.43.59.mp4
MacOS: Desktop
desktop-app-2025-01-14_15.51.33.mp4

@jjcoffee
Copy link
Contributor

@Shahidullah-Muffakir Can you add a screen recording for Android native?

@jjcoffee
Copy link
Contributor

@Shahidullah-Muffakir Should we add a test to for the wallet page too? I'm not sure where the discussion ended up, but I think the two pages aren't necessarily meant to be in-sync now, right?

@Shahidullah-Muffakir
Copy link
Contributor Author

@Shahidullah-Muffakir Can you add a screen recording for Android native?

I'm facing some issues with the Android build. I'll upload the recording once it's resolved.

@Shahidullah-Muffakir
Copy link
Contributor Author

@Shahidullah-Muffakir Should we add a test to for the wallet page too?

Sounds good, I actually tested that as well, but I’ll add the tests for it in the PR.

I'm not sure where the discussion ended up, but I think the two pages aren't necessarily meant to be in-sync now, right?

Yes, you’re right, the two pages aren’t necessarily meant to be in-sync now.

@jjcoffee
Copy link
Contributor

@Shahidullah-Muffakir I was thinking for the test steps more something like testing that the default doesn't match on the invoices pages if e.g. you manually set the first bank account as default on the invoices page.

@jjcoffee

This comment was marked as resolved.

@jjcoffee

This comment was marked as resolved.

@Shahidullah-Muffakir
Copy link
Contributor Author

BUG?: If you delete one of the bank accounts, the Make default payment method option is available on the remaining bank account (on the invoices page only).

@jjcoffee Since the BE doesn't update the default payment method when a payment method is deleted on the Invoices page (unlike on the Wallet page), we should still show the "Make the payment method default" option. This ensures that if the user deletes the default method, they can still set a new default for the remaining payment method.

@jjcoffee
Copy link
Contributor

@jjcoffee Since the BE doesn't update the default payment method when a payment method is deleted on the Invoices page (unlike on the Wallet page), we should still show the "Make the payment method default" option. This ensures that if the user deletes the default method, they can still set a new default for the remaining payment method.

@Shahidullah-Muffakir This is inconsistent with the wallet page though and I think it makes sense that they should work the same way. I think the point is that the option should be hidden if there's only one bank account, it doesn't necessarily need to reflect whether or not the BE has updated the default payment method. cc @nkuoch in case you disagree.

@Shahidullah-Muffakir
Copy link
Contributor Author

BUG?: Invoice page: newly added bank account is marked as default even when another bank account has been manually set as default (this does not happen when adding a new bank account on the wallet page).

  1. On the invoices page, add 2 bank accounts
  2. Mark the first bank account as default
  3. Delete the second bank account
  4. Add a new bank account

Expected: First bank account remains default Actual: Newly added bank account is default

That's strange, I wasn't able to reproduce the issue. One thing to note: while testing, it seems we need to use one savings and one checking account. It looks like testing accounts from different banks (like Wells Fargo and Chase) have the same account number for the same type.

Screen.20Recording.202025-01-14.20at.209.mp4

@jjcoffee
Copy link
Contributor

@Shahidullah-Muffakir Your video shows the behaviour I described - the newly added bank account is marked as default.

@Shahidullah-Muffakir
Copy link
Contributor Author

@Shahidullah-Muffakir This is inconsistent with the wallet page though and I think it makes sense that they should work the same way. I think the point is that the option should be hidden if there's only one bank account, it doesn't necessarily need to reflect whether or not the BE has updated the default payment method. cc @nkuoch in case you disagree.

@jjcoffee I see your point. It would be a bit different from the Wallet page, but if a payment method is not the default, why should we hide the "Make the payment method default" option for that payment method? Even if there's only one payment method, users should still have the option to make it the default if needed.

@Shahidullah-Muffakir
Copy link
Contributor Author

@Shahidullah-Muffakir Your video shows the behaviour I described - the newly added bank account is marked as default.

Ah, then that’s the expected behavior. The newly added bank account should be the default one. @nkuoch confirmed this with the new BE changes.

@jjcoffee
Copy link
Contributor

@jjcoffee I see your point. It would be a bit different from the Wallet page, but if a payment method is not the default, why should we hide the "Make the payment method default" option for that payment method? Even if there's only one payment method, users should still have the option to make it the default if needed.

@Shahidullah-Muffakir Because it's inconsistent and may cause confusion for the user (why do they need to set a default if there's only one bank account?). It's also the expected result in the issue:

there should be no "Make default payment method" option because there is only one bank account added (this option does not appear in Wallet when there is only one bank account).

@jjcoffee
Copy link
Contributor

@nkuoch Could you confirm that this is the expected behaviour now? I'm a bit confused as I thought we'd be tidying up inconsistencies between the wallet and invoice flows.

@Shahidullah-Muffakir
Copy link
Contributor Author

BUG?: Invoice page: newly added bank account is marked as default even when another bank account has been manually set as default (this does not happen when adding a new bank account on the wallet page).

  1. On the invoices page, add 2 bank accounts
  2. Mark the first bank account as default
  3. Delete the second bank account
  4. Add a new bank account

Expected: First bank account remains default Actual: Newly added bank account is default

@jjcoffee Even in the wallet the newly added bank account is default

@nkuoch
Copy link
Contributor

nkuoch commented Jan 15, 2025

@jjcoffee Even in the wallet the newly added bank account is default

But only when there is no prior default one, right?

Creating a PR so we don't override any previously specified default one when creating a new bank account from the invoice page.

@Shahidullah-Muffakir
Copy link
Contributor Author

Shahidullah-Muffakir commented Jan 15, 2025

But only when there is no prior default one, right?

Creating a PR so we don't override any previously specified default one when creating a new bank account from the invoice page.

@nkuoch based on the discussion from here, the newly added payment method should be set as the default
#50829 (comment)

The current behaviour:

  1. On the Wallet page, when a new payment method is added, BE returns this newly added as the default, and it override the previous default a
  2. However, what @jjcoffee mentioned here is also true in Wallet page, and it seems to contradict the first point, if a user manually sets a payment method as default using 'Make payment method default' and then adds a new payment method, the BE still returns the first payment method as default instead of returning the newly added payment as the default.

Considering this, I guess if the user manually made a payment method default by using 'Make payment method default', then adding a new payment method shouldn't override it?

@nkuoch
Copy link
Contributor

nkuoch commented Jan 15, 2025

Back end side, if a bank account is set as the default one, we can't know if it's because the user explicitly set it or because we did it when the new bank account was added.
So I guess we leave things as is and let any new bank account added from the invoice page become the new default?

@jjcoffee
Copy link
Contributor

Back end side, if a bank account is set as the default one, we can't know if it's because the user explicitly set it or because we did it when the new bank account was added.

Oh okay, that makes sense and I don't think it's a big deal from a UX perspective, it's more the inconsistency between wallet/invoice. I do wonder how the wallet page is keeping the manually set default though?

@jjcoffee
Copy link
Contributor

@nkuoch Also, sorry to bug you with so many things at once, but I feel like we've gone in circles a bit on this and wonder if you have any thoughts on this issue? Based on the issue's expected results, I would think we never show the Make default payment method if there's only one bank account.

@nkuoch
Copy link
Contributor

nkuoch commented Jan 15, 2025

I do wonder how the wallet page is keeping the manually set default though?

I tried, and it doesn't. Any new bank account gets set to the default back end side.
However, there seem to be a bug. In onyx I see defaultCredit to the right bank account, but not on display:
image

@nkuoch
Copy link
Contributor

nkuoch commented Jan 15, 2025

I would think we never show the Make default payment method if there's only one bank account.

On the invoice page, we do want to let the user specify the default explicitly (either by clicking on the default button, or by adding the bank account from the invoice page). So, if it's not the policy default one. No matter how many bank accounts we display, we want to display "Make default payment method".

On the wallet page too, but the case shouldn't occur, as back end side when deleting the bank account, we auto set the default no matter what.

@jjcoffee
Copy link
Contributor

In onyx I see defaultCredit to the right bank account, but not on display:

It looks like isDefault is the inverse - I'm not sure what the difference between those two is meant to be? 😅 I think this is the same behaviour on current staging though, so I don't think it's related to this PR.

@jjcoffee
Copy link
Contributor

I think we're nearly (finally!) done here, just to summarise where we're at:

  1. @Shahidullah-Muffakir Android native screen recording.
  2. @Shahidullah-Muffakir Add a test step to verify that the defaults are independent between the invoices and wallet pages if e.g. you manually set the first bank account as default on the invoices page, it will not be the same on the wallet page. We may also want a test step to cover the "new" behaviour that Make default payment method is still available when only one bank account is available (on invoices page only).
  3. BUG?: If you delete one of the bank accounts, the Make default payment method option is available on the remaining bank account (on the invoices page only). Deemed to be not a bug, per @nkuoch's comment.
  4. BUG?: Invoice page: newly added bank account is marked as default even when another bank account has been manually set as default (this does not happen when adding a new bank account on the wallet page). Deemed to be not a bug/unfixable, per @nkuoch's comment.

@Shahidullah-Muffakir
Copy link
Contributor Author

@jjcoffee I've added the updated Tests and Android recording.

Copy link
Contributor

@jjcoffee jjcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Assuming my understanding here is correct, regarding the "bugs" I found.

I think we can probably leave the lint fixes as they weren't introduced by this PR, and it'd be good to just get this one finished.

@melvin-bot melvin-bot bot requested a review from nkuoch January 16, 2025 10:45
@nkuoch nkuoch merged commit 1dbf9a4 into Expensify:main Jan 16, 2025
19 of 20 checks passed
@melvin-bot melvin-bot bot added the Emergency label Jan 16, 2025
Copy link

melvin-bot bot commented Jan 16, 2025

@nkuoch looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@nkuoch nkuoch removed the Emergency label Jan 16, 2025
@nkuoch
Copy link
Contributor

nkuoch commented Jan 16, 2025

eslint errors weren't introduced by this PR

Copy link
Contributor

🚀 Deployed to staging by https://github.com/nkuoch in version: 9.0.87-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 success ✅
🍎🔄 iOS HybridApp 🍎🔄 success ✅

Copy link
Contributor

🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.87-3 🚀

platform result
🤖 android 🤖 true ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 failure ❌
🍎🔄 iOS HybridApp 🍎🔄 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants