Create Expense Part 2 - Clean up

[JKobrynski]

Explanation of Change

After we Made 'Create Expense' our mainline flow, the next step was to clean up the code that was left after the now deprecated flows were removed.

Fixed Issues

$ #54006
PROPOSAL: N/A

Tests

1. Log into the app
2. Click on the FAB and select 'Create expense'
3. Make sure you can submit expenses with no issues
4. Repeat on different accounts and make sure is still works and you can't see the Submit/Track Expense options in FAB

• Verify that no errors appear in the JS console

Offline tests

Same as Tests section above.

QA Steps

Same as Tests section above.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[melvin-bot]

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[JKobrynski]

@grgia would you like to take a look too?

[mananjadhav]

I did partial review, I'll finish this today.

[JKobrynski]

@mananjadhav sure thing, thank you! I tagged Georgia because we discussed this issue before and I thought she might want to take a look too 😄

[mananjadhav]

Indeed yes. I was just posting an update on all PRs :)

[JKobrynski]

@mananjadhav @grgia can we get this merged or do you think it's not ready yet?

[mananjadhav]

I was out sick for last few days. I'll cover this today.

[mananjadhav]

I reviewed the code changes. While the current cleanup is okay, I wanted to clarify @JKobrynski @grgia if we would want to rename all instances of Submit Expense and Track Expense with Create Expense. I can see a few buttons with the usage of iou.submitExpense and iou.trackExpense

[mananjadhav]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

web-create-expense-1.mov

web-create-expense-2.mov

web-create-expense.mov

MacOS: Desktop

desktop-create-expense.mov

[mananjadhav]

Approving this pending #54201 (comment)

[grgia]

Per #54201 (comment)

I think yes, let's clean up the instances of track and submit. WDYT @JKobrynski ?

Could you ping me when this is ready for a final test build

[mananjadhav]

@grgia Does that mean even for self DM we'll always show Create Expense?

[JKobrynski]

@grgia Does that mean even for self DM we'll always show Create Expense?

@grgia can you confirm? 🙏

[mananjadhav]

and @grgia would be great if you could check these screens too. The Track Expense button at the bottom as well as Tracking ... in the report header as well as RHP.

cc - @JKobrynski for your eyes too.

[grgia]

@mananjadhav @JKobrynski

@grgia Does that mean even for self DM we'll always show Create Expense?

I think yes, we will always show "Create" for any expense creation. Even if it's the self-DM

and @grgia would be great if you could check these screens too. The Track Expense button at the bottom as well as Tracking ... in the report header as well as RHP.

The report header should not be changed in this PR. The Track Expense button should say "Create Expense"

Hey @trjExpensify Can you confirm these Create Expense Q/As?

[trjExpensify]

I think yes, we will always show "Create" for any expense creation. Even if it's the self-DM

Yep, that's what we had in the experiment that won out, so we should make that change permanent:

The report header should not be changed in this PR.

I'm cool with not changing that here too, though we should probably look at where there's instances of that in the track expense flows. I don't see why the report titles need this "Tracking..." before the amount and merchant||description.

[grgia]

@trjExpensify

I don't see why the report titles need this "Tracking..." before the amount and merchant||description.

I think this is going to be a BE issue... but I haven't checked on FE.

Maybe @thienlnam knows why we do this for tracked expenses?

[trjExpensify]

Yeah, all good. I agree we don't need to look at changing that in this PR specifically.

[mananjadhav]

Reviewing the changes now.

[mananjadhav]

I tested the follow up changes and uploaded the screencast for web.

But I've been testing this more. Still found a few places to cover.

1. Track expense showing up in quick actions.

2. A few places in the code I see, here, here, here.

3. There's also a place in ReportUtil iou.trackExpense but I am not sure how to reproduce it and I am not sure if we should remove them.

4. What about the instances in the translation files.

[JKobrynski]

@mananjadhav on it!

[JKobrynski]

Eslint issues fixed, ready for review!

CC: @mananjadhav @grgia

[github-actions]

🚧 @grgia has triggered a test build. You can view the workflow run here.

[mananjadhav]

Thanks. I’ll review this in an hour.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/54201/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/54201/index.html
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/54201/NewExpensify.dmg	https://54201.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[mananjadhav]

The updated code changes look fine. Doing the final round of testing. I think if there's any edge case that's left out we can fix it in the follow up. This is anyway getting bloated.

[mananjadhav]

Reviewed all the recent changes and some sanity.

Thanks @JKobrynski for all the patience. @grgia All yours.

[grgia]

Let's hold merging this on #55016

[mananjadhav]

Okay. I am going to test the PR soon. I'll focus on it today, I thought PRs were independent.

[fabioh8010]

Just a heads up that @JKobrynski has been on OOO since Monday and will return tomorrow.

[github-actions]

🚧 @grgia has triggered a test build. You can view the workflow run here.

[grgia]

Going to merge this one when tests pass

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/54201/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/54201/NewExpensify.dmg	https://54201.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[github-actions]

🚀 Deployed to staging by https://github.com/grgia in version: 9.0.87-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

[github-actions]

🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.87-3 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅