refactor(commonTests): split up helpers into individual modules #9112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7cc1475 to
c750615
Compare
jcfranco
approved these changes
Apr 19, 2024
| ComponentTestContent, | ||
| ComponentTestSetup, | ||
| getTagOrHTMLWithBeforeContent, | ||
| HYDRATED_ATTR, |
There was a problem hiding this comment.
Except for HYDRATED_ATTR, the rest should not be exported as they are internal to the common test modules.
Sidebar: can you create a follow-up issue to update/remove tests using it in favor of renders?
|
After installing, please merge into #8594. cc @alisonailea |
jcfranco
requested changes
Apr 22, 2024
packages/calcite-components/src/tests/commonTests/accessible.ts
Outdated
Show resolved
Hide resolved
jcfranco
approved these changes
Apr 22, 2024
jcfranco
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #9056
Summary
Split up commonTest helpers into individual modules.