refactor(commonTests): split up helpers into individual modules (#9112)

**Related Issue:** #9056 ## Summary Split up commonTest helpers into individual modules.
Esri · Apr 22, 2024 · bdd19c7 · bdd19c7
1 parent 30cccde
commit bdd19c7
Show file tree

Hide file tree

Showing 20 changed files with 1,968 additions and 1,848 deletions.
diff --git a/packages/calcite-components/.eslintrc.cjs b/packages/calcite-components/.eslintrc.cjs
@@ -91,6 +91,18 @@ module.exports = {
       },
     ],
     "no-new-func": "error",
+    "no-restricted-imports": [
+      "error",
+      {
+        patterns: [
+          {
+            group: ["tests/commonTests/*"],
+            message:
+              "Import named functions from commonTests instead of direct module imports, e.g., import { disabled } from 'tests/commonTests'",
+          },
+        ],
+      },
+    ],
     "no-unneeded-ternary": "error",
     "one-var": ["error", "never"],
     "react/forbid-component-props": [
@@ -155,10 +167,16 @@ module.exports = {
       ignorePrivate: true,
     },
   },
-  overrides: [{
-    files: ["**/*.e2e.ts", "src/tests/**/*"],
-    rules: {
-      "@esri/calcite-components/no-dynamic-createelement": "off",
-    }
-  }]
+  overrides: [
+    {
+      files: ["**/*.e2e.ts", "src/tests/**/*"],
+      rules: {
+        "@esri/calcite-components/no-dynamic-createelement": "off",
+      },
+    },
+    {
+      extends: ["plugin:@typescript-eslint/disable-type-checked"],
+      files: ["*.cjs"],
+    },
+  ],
 };
diff --git a/packages/calcite-components/src/components/input-time-zone/input-time-zone.e2e.ts b/packages/calcite-components/src/components/input-time-zone/input-time-zone.e2e.ts
@@ -11,8 +11,8 @@ import {
   reflects,
   renders,
   t9n,
-  TagAndPage,
 } from "../../tests/commonTests";
+import { TagAndPage } from "../../tests/commonTests/interfaces";
 import { toUserFriendlyName } from "./utils";
 
 describe("calcite-input-time-zone", () => {