Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split up commonTest helpers into individual modules #9056

Closed
1 of 5 tasks
jcfranco opened this issue Apr 3, 2024 · 2 comments
Closed
1 of 5 tasks

split up commonTest helpers into individual modules #9056

jcfranco opened this issue Apr 3, 2024 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. calcite-components Issues specific to the @esri/calcite-components package. refactor Issues tied to code that needs to be significantly reworked.
Milestone
2024-04-30 - Apr ...

Comments

@jcfranco
Copy link
Member

jcfranco commented Apr 3, 2024

Description

commonTests has grown since we introduced it and it's time to split it up to make it easier to follow and maintain.

Stems from #9027 (comment).

Proposed Advantages

Test helpers should be easier to follow and maintain.

Which Component

commonTests

Relevant Info

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components
@jcfranco jcfranco added refactor Issues tied to code that needs to be significantly reworked. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Apr 3, 2024
@github-actions github-actions bot added the calcite-components Issues specific to the @esri/calcite-components package. label Apr 3, 2024
@Elijbet Elijbet self-assigned this Apr 3, 2024
@Elijbet Elijbet added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Apr 3, 2024
@jcfranco jcfranco mentioned this issue Apr 4, 2024
Merged
@Elijbet Elijbet mentioned this issue Apr 10, 2024
Merged
@Elijbet Elijbet added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Apr 11, 2024
Elijbet added a commit that referenced this issue Apr 22, 2024
@Elijbet
refactor(commonTests): split up helpers into individual modules (#9112)
bdd19c7 
**Related Issue:** #9056

## Summary
Split up commonTest helpers into individual modules.
@geospatialem geospatialem added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. needs triage Planning workflow - pending design/dev review. labels Sep 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@github-actions github-actions bot assigned DitwanP and unassigned Elijbet Sep 26, 2024
@geospatialem geospatialem added this to the 2024-04-30 - Apr Release milestone Sep 26, 2024
@DitwanP
Copy link
Contributor

DitwanP commented Sep 26, 2024

🍠

@DitwanP DitwanP closed this as completed Sep 26, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. calcite-components Issues specific to the @esri/calcite-components package. refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
2024-04-30 - Apr Release
Development

No branches or pull requests
4 participants
@jcfranco @geospatialem @Elijbet @DitwanP