Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(commonTests): split up helpers into individual modules #9112

Merged
merged 32 commits into from
Apr 22, 2024
+1,968 −1,848
Merged

refactor(commonTests): split up helpers into individual modules #9112

Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
9743975
refactor(commonTests): split up helpers into individual modules
Elijbet Apr 10, 2024
11d71c1
formAssociated
Elijbet Apr 10, 2024
404b995
disabled
Elijbet Apr 10, 2024
55957a8
commonTests
Elijbet Apr 10, 2024
7470e97
floatingUI
Elijbet Apr 10, 2024
c750615
t9n
Elijbet Apr 10, 2024
2b6bba1
export through index.ts
Elijbet Apr 16, 2024
12f8d5e
split up remaining tests and update imports
Elijbet Apr 17, 2024
58a946a
rename setupForTests into utils
Elijbet Apr 17, 2024
6313291
merge conflicst - commonTests.ts removed
Elijbet Apr 17, 2024
eb29ce2
update utils.ts imports
Elijbet Apr 17, 2024
bf7ad69
exports
Elijbet Apr 17, 2024
a5f1d7d
cleanup
Elijbet Apr 17, 2024
2be734f
remove unreachable code
Elijbet Apr 17, 2024
5db82b6
cleanup
Elijbet Apr 18, 2024
7cdb70e
undo changes related to TS errors
Elijbet Apr 18, 2024
0325fb8
undo TS error related changes in floatingUI.ts
Elijbet Apr 18, 2024
11d1cdf
undo forcusable
Elijbet Apr 18, 2024
2893a98
formAssociated
Elijbet Apr 18, 2024
d0e504d
labelable
Elijbet Apr 18, 2024
0418072
openClose
Elijbet Apr 18, 2024
79f0b55
slots and t9n
Elijbet Apr 18, 2024
345fd73
enable eslint rule for no-restricted-imports
Elijbet Apr 19, 2024
23d2730
cleanup
Elijbet Apr 19, 2024
5f53be5
remove each eslint-disable line by adding an overriding jest rule
Elijbet Apr 19, 2024
9d1596b
dedicated interfaces.ts
Elijbet Apr 22, 2024
bc6612f
interfaces.ts imports
Elijbet Apr 22, 2024
bfc0990
cleanup
Elijbet Apr 22, 2024
2ec94ea
commonTests dedicated eslintrc.cjs
Elijbet Apr 22, 2024
f479226
cleanup
Elijbet Apr 22, 2024
5314500
cleanup
Elijbet Apr 22, 2024
3e1425c
cleanup
Elijbet Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Loading
Loading status checks…
cleanup
@Elijbet
Elijbet committed Apr 17, 2024
commit a5f1d7dc9c8cca7d5b7abac2559b562dc03e2d29
1 change: 1 addition & 0 deletions packages/calcite-components/src/tests/commonTests/index.ts
View file
Original file line number Diff line number Diff line change
@@ -22,4 +22,5 @@ export {
ComponentTestContent,
ComponentTestSetup,
getTagOrHTMLWithBeforeContent,
HYDRATED_ATTR,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for HYDRATED_ATTR, the rest should not be exported as they are internal to the common test modules.

Sidebar: can you create a follow-up issue to update/remove tests using it in favor of renders?

Copy link
Contributor Author

@Elijbet Elijbet Apr 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup. Here: #9166

} from "./utils";