fix(input-time-zone): fix handling of unknown and cityless time zones from offset display mode #7947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es from offset display mode
alisonailea
reviewed
Oct 5, 2023
| @@ -4,6 +4,48 @@ import { InputTimeZoneMessages } from "./assets/input-time-zone/t9n"; | |||
|
|
|||
| const hourToMinutes = 60; | |||
|
|
|||
| const timeZoneNameBlockList = [ | |||
There was a problem hiding this comment.
Is there a way to get this list from a trusted source rather than having to maintain it ourselves?
There was a problem hiding this comment.
Good idea. I could reliably exclude Etc/X ones, but would have to investigate separately if entries with no delimiter are reliable to block as well.
There was a problem hiding this comment.
I focused too much on having this dynamically generated that I didn't address the "trusted source" part of your question. Unfortunately, Intl doesn't provide metadata for time zone names, so we have to handle this on our side. That would definitely make things simpler here.
Merged
geospatialem
pushed a commit
that referenced
this pull request
Oct 6, 2023
🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-components: 1.9.1</summary> ## [1.9.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@1.9.0...@esri/calcite-components@1.9.1) (2023-10-05) ### Bug Fixes * **combobox:** Fix issue causing value to be cleared when selecting an item (Windows + trackpad) ([#7954](#7954)) ([557d658](557d658)) * **input-time-zone:** Fix handling of unknown and cityless time zones from offset display mode ([#7947](#7947)) ([75e0302](75e0302)) * **panel:** Fix collapse action title and reverse icon direction ([#7927](#7927)) ([5f620f8](5f620f8)) </details> <details><summary>@esri/calcite-components-react: 1.9.1</summary> ## [1.9.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@1.9.0...@esri/calcite-components-react@1.9.1) (2023-10-05) ### Miscellaneous Chores * **@esri/calcite-components-react:** Synchronize undefined versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^1.9.1-next.1 to ^1.9.1 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
benelan
added a commit
that referenced
this pull request
Oct 11, 2023
* origin/main: (83 commits) chore: add design tokens to monorepo (#7948) test(input-time-zone): restore common tests (#7963) chore: release next fix(input-time-zone): fix error caused by time zone group filtering (#7971) chore: release next fix(table): Improve scrollbar display (#7967) build: bump timezone-groups (#7962) chore: release next fix(flow-item): update collapsed property when collapse button is clicked (#7960) chore: release main (#7945) chore: release next fix(input-time-zone): fix handling of unknown and cityless time zones from offset display mode (#7947) fix(combobox): fix issue causing value to be cleared when selecting an item (Windows + trackpad) (#7954) chore(deps): update calcite-ui-icons to 3.24.7 (#7949) test(flow-item, panel): add tests for internal property. (#7931) chore: release next fix(panel): fix collapse action title and reverse icon direction (#7927) chore: update issue template labels to support workflows (#7938) build(deps): bump timezone-groups (#7933) build(deps): update dependency @esri/calcite-ui-icons to v3.24.6 (#7925) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #7944
Summary
This updates the component to remove cityless time zone entries in the
offsetmode and for unknown entries (either from browser differences or updated values) their city part will be displayed as is.Note: due to time constraints, testing will be tackled in #7951.