Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(table): Improve scrollbar display #7967

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

macandcheese
Copy link
Contributor

Related Issue: #7892

Summary

Updates the css rule to only display scrollbars in Windows when scrolling is occurring.

Before After
Screenshot 2023-10-09 at 10 06 40 AM Screenshot 2023-10-09 at 10 06 51 AM

Tested / screenshots taken through Windows VM.

@macandcheese macandcheese added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Oct 9, 2023
@macandcheese macandcheese requested a review from a team as a code owner October 9, 2023 19:33
@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Oct 9, 2023
@macandcheese macandcheese added the low risk Issues with low risk for consideration in low risk milestones label Oct 9, 2023
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@macandcheese macandcheese merged commit 593a1bf into main Oct 10, 2023
@macandcheese macandcheese deleted the macandcheese/7892-table-scrolling-style branch October 10, 2023 21:24
@github-actions github-actions bot added this to the 1.10.0 Maintenance Release milestone Oct 10, 2023
benelan added a commit that referenced this pull request Oct 11, 2023
* origin/main: (83 commits)
  chore: add design tokens to monorepo (#7948)
  test(input-time-zone): restore common tests (#7963)
  chore: release next
  fix(input-time-zone): fix error caused by time zone group filtering (#7971)
  chore: release next
  fix(table): Improve scrollbar display (#7967)
  build: bump timezone-groups (#7962)
  chore: release next
  fix(flow-item): update collapsed property when collapse button is clicked (#7960)
  chore: release main (#7945)
  chore: release next
  fix(input-time-zone): fix handling of unknown and cityless time zones from offset display mode (#7947)
  fix(combobox): fix issue causing value to be cleared when selecting an item (Windows + trackpad) (#7954)
  chore(deps): update calcite-ui-icons to 3.24.7 (#7949)
  test(flow-item, panel): add tests for internal property. (#7931)
  chore: release next
  fix(panel): fix collapse action title and reverse icon direction (#7927)
  chore: update issue template labels to support workflows (#7938)
  build(deps): bump timezone-groups (#7933)
  build(deps): update dependency @esri/calcite-ui-icons to v3.24.6 (#7925)
  ...
geospatialem pushed a commit that referenced this pull request Oct 12, 2023
🤖 I have created a release *beep* *boop*
---


<details><summary>@esri/calcite-components: 1.9.2</summary>

##
[1.9.2](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@1.9.1...@esri/calcite-components@1.9.2)
(2023-10-12)


### Bug Fixes

* **flow-item:** Update collapsed property when collapse button is
clicked
([#7960](#7960))
([f6fd55f](f6fd55f))
* **input-time-zone:** Allow searching offsets by Etc/x time zone
([#7978](#7978))
([2c34b42](2c34b42))
* **input-time-zone:** Fix error caused by time zone group filtering
([#7971](#7971))
([521673e](521673e))
* **table:** Improve scrollbar display
([#7967](#7967))
([593a1bf](593a1bf))
</details>

<details><summary>@esri/calcite-components-react: 1.9.2</summary>

##
[1.9.2](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@1.9.1...@esri/calcite-components-react@1.9.2)
(2023-10-12)


### Miscellaneous Chores

* **@esri/calcite-components-react:** Synchronize undefined versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from ^1.9.2-next.3 to ^1.9.2
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. low risk Issues with low risk for consideration in low risk milestones pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants