-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(input-time-zone): restore common tests #7963
Merged
jcfranco
merged 4 commits into
main
from
jcfranco/7951-restore-input-time-zone-common-tests
Oct 11, 2023
Merged
test(input-time-zone): restore common tests #7963
jcfranco
merged 4 commits into
main
from
jcfranco/7951-restore-input-time-zone-common-tests
Oct 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfranco
added
the
skip visual snapshots
Pull requests that do not need visual regression testing.
label
Oct 7, 2023
github-actions
bot
added
the
testing
Issues related to automated or manual testing.
label
Oct 7, 2023
jcfranco
added
the
low risk
Issues with low risk for consideration in low risk milestones
label
Oct 10, 2023
benelan
approved these changes
Oct 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noice!
<!-- | ||
keeping things simple by using submit-type input | ||
this should cover button and calcite-button submit cases | ||
--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<Insert whatever is below 'Nitpick'>
: weird indenting
jcfranco
deleted the
jcfranco/7951-restore-input-time-zone-common-tests
branch
October 11, 2023 00:32
benelan
added a commit
that referenced
this pull request
Oct 11, 2023
* origin/main: (83 commits) chore: add design tokens to monorepo (#7948) test(input-time-zone): restore common tests (#7963) chore: release next fix(input-time-zone): fix error caused by time zone group filtering (#7971) chore: release next fix(table): Improve scrollbar display (#7967) build: bump timezone-groups (#7962) chore: release next fix(flow-item): update collapsed property when collapse button is clicked (#7960) chore: release main (#7945) chore: release next fix(input-time-zone): fix handling of unknown and cityless time zones from offset display mode (#7947) fix(combobox): fix issue causing value to be cleared when selecting an item (Windows + trackpad) (#7954) chore(deps): update calcite-ui-icons to 3.24.7 (#7949) test(flow-item, panel): add tests for internal property. (#7931) chore: release next fix(panel): fix collapse action title and reverse icon direction (#7927) chore: update issue template labels to support workflows (#7938) build(deps): bump timezone-groups (#7933) build(deps): update dependency @esri/calcite-ui-icons to v3.24.6 (#7925) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
low risk
Issues with low risk for consideration in low risk milestones
skip visual snapshots
Pull requests that do not need visual regression testing.
testing
Issues related to automated or manual testing.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #7951
Summary
✨🧪✨
This also updates test helpers to accept additional test setup options.