Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(input-time-zone): restore common tests #7963

Merged
merged 4 commits into from
Oct 11, 2023

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Oct 7, 2023

Related Issue: #7951

Summary

✨🧪✨

This also updates test helpers to accept additional test setup options.

@jcfranco jcfranco added the skip visual snapshots Pull requests that do not need visual regression testing. label Oct 7, 2023
@github-actions github-actions bot added the testing Issues related to automated or manual testing. label Oct 7, 2023
@jcfranco jcfranco added the low risk Issues with low risk for consideration in low risk milestones label Oct 10, 2023
@jcfranco jcfranco marked this pull request as ready for review October 10, 2023 19:10
@jcfranco jcfranco requested a review from a team as a code owner October 10, 2023 19:10
Copy link
Member

@benelan benelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice!

<!--
keeping things simple by using submit-type input
this should cover button and calcite-button submit cases
-->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<Insert whatever is below 'Nitpick'>: weird indenting

@jcfranco jcfranco merged commit 75e16db into main Oct 11, 2023
@jcfranco jcfranco deleted the jcfranco/7951-restore-input-time-zone-common-tests branch October 11, 2023 00:32
@github-actions github-actions bot added this to the 1.10.0 Maintenance Release milestone Oct 11, 2023
benelan added a commit that referenced this pull request Oct 11, 2023
* origin/main: (83 commits)
  chore: add design tokens to monorepo (#7948)
  test(input-time-zone): restore common tests (#7963)
  chore: release next
  fix(input-time-zone): fix error caused by time zone group filtering (#7971)
  chore: release next
  fix(table): Improve scrollbar display (#7967)
  build: bump timezone-groups (#7962)
  chore: release next
  fix(flow-item): update collapsed property when collapse button is clicked (#7960)
  chore: release main (#7945)
  chore: release next
  fix(input-time-zone): fix handling of unknown and cityless time zones from offset display mode (#7947)
  fix(combobox): fix issue causing value to be cleared when selecting an item (Windows + trackpad) (#7954)
  chore(deps): update calcite-ui-icons to 3.24.7 (#7949)
  test(flow-item, panel): add tests for internal property. (#7931)
  chore: release next
  fix(panel): fix collapse action title and reverse icon direction (#7927)
  chore: update issue template labels to support workflows (#7938)
  build(deps): bump timezone-groups (#7933)
  build(deps): update dependency @esri/calcite-ui-icons to v3.24.6 (#7925)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low risk Issues with low risk for consideration in low risk milestones skip visual snapshots Pull requests that do not need visual regression testing. testing Issues related to automated or manual testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants