Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Input Time Zone] Doesn't display in Firefox browsers and console errors are present #7944

Closed
2 of 4 tasks
geospatialem opened this issue Oct 5, 2023 · 6 comments
Closed
2 of 4 tasks

[Input Time Zone] Doesn't display in Firefox browsers and console errors are present #7944

geospatialem opened this issue Oct 5, 2023 · 6 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. browser-firefox Issues tied to the last 2 versions of Firefox browser. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality regression Issues that are caused by changes in a release, but were working before that.
Milestone
1.9.2 Maintenance...

Comments

@geospatialem
Copy link
Member

Check existing issues

Actual Behavior

The Maps SDK for JS Editor form relies on the Time Zone component, which doesn't display in 1.9.0. There are also errors on the page:

Uncaught (in promise) TypeError: format: expected string, got undefined
createTimeZoneItems https://js.arcgis.com/calcite-components/1.9.0/p-fcc3a585.entry.js:6
createTimeZoneItems https://js.arcgis.com/calcite-components/1.9.0/p-fcc3a585.entry.js:6

Expected Behavior

Similar to 1.8.0, the component displays and no console errors are present.

Reproduction Sample

https://codepen.io/geospatialem/pen/zYyMrpY

Reproduction Steps

  1. Open https://codepen.io/geospatialem/pen/zYyMrpY with Firefox
  2. Contact Kitty for username/password
  3. Click on the Edit Features "Select"
  4. Select a point to edit
  5. Select one of the objects in the list
  6. Open the browser console
  7. Observe the behavior and errors of:

Uncaught (in promise) TypeError: format: expected string, got undefined
createTimeZoneItems https://js.arcgis.com/calcite-components/1.9.0/p-fcc3a585.entry.js:6
createTimeZoneItems https://js.arcgis.com/calcite-components/1.9.0/p-fcc3a585.entry.js:6

Reproduction Version

1.9.0

Relevant Info

Seems specific to Firefox browsers

Regression?

1.8.0

Priority impact

p1 - need for current milestone

Impact

Very high - impacts MapViewer and Maps SDK for JS teams in the upcoming release Monday.

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Map Viewer
@geospatialem geospatialem added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. browser-firefox Issues tied to the last 2 versions of Firefox browser. p - high Issue should be addressed in the current milestone, impacts component or core functionality 1 - assigned Issues that are assigned to a sprint and a team member. regression Issues that are caused by changes in a release, but were working before that. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. labels Oct 5, 2023
@github-actions github-actions bot added impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone calcite-components Issues specific to the @esri/calcite-components package. ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. labels Oct 5, 2023
@geospatialem
Copy link
Member Author

cc @rebollin @JonUihlein @hgonzago

@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Oct 5, 2023
This was referenced Oct 5, 2023
Closed
Merged
jcfranco added a commit that referenced this issue Oct 5, 2023
@jcfranco
fix(input-time-zone): fix handling of unknown and cityless time zones…
75e0302 
… from offset display mode (#7947)

**Related Issue:** #7944

## Summary

This updates the component to remove cityless time zone entries in the
`offset` mode and for unknown entries (either from browser differences
or updated values) their city part will be displayed as is.

**Note**: due to time constraints, testing will be tackled in #7951.
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Oct 5, 2023
@github-actions github-actions bot assigned geospatialem and unassigned jcfranco Oct 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Oct 5, 2023
@geospatialem
Copy link
Member Author

Verified in 1.9.1-next.1 with Firefox.

@jcfranco jcfranco mentioned this issue Oct 10, 2023
Merged
@geospatialem geospatialem added 2 - in development Issues that are actively being worked on. and removed 4 - verified Issues that have been released and confirmed resolved. labels Oct 10, 2023
@geospatialem geospatialem removed their assignment Oct 10, 2023
@geospatialem geospatialem reopened this Oct 10, 2023
jcfranco added a commit that referenced this issue Oct 10, 2023
@jcfranco
fix(input-time-zone): fix error caused by time zone group filtering (#…
521673e 
…7971)

**Related Issue:** #7944

## Summary

Addresses an issue caused by time zone label index adjustment (from time
zone group filtering) ended up as -1 and cause an error when using it as
a lookup index.

This also adds missing tests from
#7947.
@jcfranco
Copy link
Member

For context, we reopened due to bug in certain time zone grouping scenario.

@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Oct 10, 2023
@github-actions github-actions bot assigned geospatialem and unassigned jcfranco Oct 10, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Oct 12, 2023
@geospatialem
Copy link
Member Author

Verified in 1.9.2-next.3 with Firefox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. browser-firefox Issues tied to the last 2 versions of Firefox browser. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality regression Issues that are caused by changes in a release, but were working before that.
Projects
None yet
Milestone
1.9.2 Maintenance Release
Development

No branches or pull requests
2 participants
@jcfranco @geospatialem