Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(notice): ensure closed notice does not affect layout #10518

Merged
merged 3 commits into from
Oct 10, 2024
Merged

fix(notice): ensure closed notice does not affect layout #10518

merged 3 commits into from
Oct 10, 2024

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Oct 10, 2024 •
edited
Loading

Related Issue: #10516

Summary

Fixes regression introduced by 7e2764f#diff-eef7cf73b4f6571be27053eba0e491f478a9569a26f5f2571a590a18bebfc591.

Noteworthy changes

  • updates openClose test helper with option to assert on collapsed layout
  • adds util to get ElementHandle and updates applicable tests

@jcfranco
fix(notice): ensure closed notice does not affect layout
a80b3a1
@jcfranco
add e2e test coverage
6a053d4 
* updates `openClose` test helper with option to assert on collapsed layout
* adds util to get ElementHandle and updates applicable tests
@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Oct 10, 2024
@jcfranco jcfranco added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Oct 10, 2024
benelan
benelan approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@benelan benelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Oct 10, 2024
@jcfranco jcfranco merged commit f289020 into dev Oct 10, 2024
14 checks passed
@jcfranco jcfranco deleted the jcfranco/10516-fix-notice-closed-layout-regression branch October 10, 2024 04:40
@github-actions github-actions bot added this to the 2.13.1 patch milestone Oct 10, 2024
benelan pushed a commit that referenced this pull request Oct 11, 2024
@jcfranco @benelan
fix(notice): ensure closed notice does not affect layout (#10518)
871344a
@benelan benelan mentioned this pull request Oct 11, 2024
Merged
benelan pushed a commit that referenced this pull request Oct 11, 2024
@jcfranco @benelan
fix(notice): ensure closed notice does not affect layout (#10518)
655bbb7
This was referenced Oct 11, 2024
Closed
Merged
benelan added a commit that referenced this pull request Oct 11, 2024
@calcite-admin @benelan
chore: release main (#10530)
6704555 
🤖 I have created a release *beep* *boop*
---


<details><summary>@esri/calcite-components: 2.13.1</summary>

##
[2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.13.0...@esri/calcite-components@2.13.1)
(2024-10-11)


### Bug Fixes

* **chip:** Fix close icon color inconsistency
([#10493](#10493))
([80b75c2](80b75c2))
* **combobox:** Restores `filterText` when filtered items are empty
([#10498](#10498))
([6667c2a](6667c2a))
* **dialog:** No longer apply transform styling unless dragEnabled or
resizable
([#10503](#10503))
([e93fdbc](e93fdbc))
* **notice:** Ensure closed notice does not affect layout
([#10518](#10518))
([655bbb7](655bbb7))
* **fix(panel):** Revert relative positioning on content
([#10496](#10496))
([239f4da](239f4da))
</details>

<details><summary>@esri/calcite-components-angular: 2.13.1</summary>

##
[2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.13.0...@esri/calcite-components-angular@2.13.1)
(2024-10-11)


### Miscellaneous Chores

* **@esri/calcite-components-angular:** Synchronize components versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 2.13.0 to 2.13.1
</details>

<details><summary>@esri/calcite-components-react: 2.13.1</summary>

##
[2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.13.0...@esri/calcite-components-react@2.13.1)
(2024-10-11)


### Miscellaneous Chores

* **@esri/calcite-components-react:** Synchronize components versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 2.13.0 to 2.13.1
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: Ben Elan <no-reply@benelan.dev>
benelan added a commit that referenced this pull request Oct 11, 2024
@calcite-admin @benelan
chore: release main (#10530)
922968b 
🤖 I have created a release *beep* *boop*
---

<details><summary>@esri/calcite-components: 2.13.1</summary>

[2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.13.0...@esri/calcite-components@2.13.1)
(2024-10-11)

* **chip:** Fix close icon color inconsistency
([#10493](#10493))
([80b75c2](80b75c2))
* **combobox:** Restores `filterText` when filtered items are empty
([#10498](#10498))
([6667c2a](6667c2a))
* **dialog:** No longer apply transform styling unless dragEnabled or
resizable
([#10503](#10503))
([e93fdbc](e93fdbc))
* **notice:** Ensure closed notice does not affect layout
([#10518](#10518))
([655bbb7](655bbb7))
* **fix(panel):** Revert relative positioning on content
([#10496](#10496))
([239f4da](239f4da))
</details>

<details><summary>@esri/calcite-components-angular: 2.13.1</summary>

[2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.13.0...@esri/calcite-components-angular@2.13.1)
(2024-10-11)

* **@esri/calcite-components-angular:** Synchronize components versions

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 2.13.0 to 2.13.1
</details>

<details><summary>@esri/calcite-components-react: 2.13.1</summary>

[2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.13.0...@esri/calcite-components-react@2.13.1)
(2024-10-11)

* **@esri/calcite-components-react:** Synchronize components versions

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 2.13.0 to 2.13.1
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: Ben Elan <no-reply@benelan.dev>
@benelan benelan mentioned this pull request Oct 11, 2024
Merged
benelan added a commit that referenced this pull request Oct 11, 2024
@benelan @calcite-admin
chore: release main (#10530)
3546253 
🤖 I have created a release *beep* *boop*
---

<details><summary>@esri/calcite-components: 2.13.1</summary>


[2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.13.0...@esri/calcite-components@2.13.1)
(2024-10-11)

* **chip:** Fix close icon color inconsistency
([#10493](#10493))

([80b75c2](80b75c2))
* **combobox:** Restores `filterText` when filtered items are empty
([#10498](#10498))

([6667c2a](6667c2a))
* **dialog:** No longer apply transform styling unless dragEnabled or
resizable
([#10503](#10503))

([e93fdbc](e93fdbc))
* **notice:** Ensure closed notice does not affect layout
([#10518](#10518))

([655bbb7](655bbb7))
* **fix(panel):** Revert relative positioning on content
([#10496](#10496))

([239f4da](239f4da))
</details>

<details><summary>@esri/calcite-components-angular: 2.13.1</summary>


[2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.13.0...@esri/calcite-components-angular@2.13.1)
(2024-10-11)

* **@esri/calcite-components-angular:** Synchronize components versions

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 2.13.0 to 2.13.1
</details>

<details><summary>@esri/calcite-components-react: 2.13.1</summary>


[2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.13.0...@esri/calcite-components-react@2.13.1)
(2024-10-11)

* **@esri/calcite-components-react:** Synchronize components versions

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 2.13.0 to 2.13.1
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See

[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: Calcite Admin <calcite-admin@esri.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benelan benelan benelan approved these changes

@driskull driskull Awaiting requested review from driskull

@alisonailea alisonailea Awaiting requested review from alisonailea

@macandcheese macandcheese Awaiting requested review from macandcheese

Assignees

@jcfranco jcfranco

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
2.13.1 patch
Development

Successfully merging this pull request may close these issues.
2 participants
@jcfranco @benelan