Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(panel): revert relative positioning on content #10496

Merged
merged 4 commits into from
Oct 10, 2024
Merged

fix(panel): revert relative positioning on content #10496

merged 4 commits into from
Oct 10, 2024

Conversation

driskull
Copy link
Member

@driskull driskull commented Oct 7, 2024 •
edited
Loading

Related Issue: #10494 #10095

BEGIN_COMMIT_OVERRIDE
fix(panel): revert relative positioning on content #10494
END_COMMIT_OVERRIDE

Summary

@driskull driskull requested a review from jcfranco October 7, 2024 20:22
@driskull driskull self-assigned this Oct 7, 2024
@driskull driskull added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Oct 7, 2024
@github-actions github-actions bot added the chore Issues with changes that don't modify src or test files. label Oct 7, 2024
@driskull driskull closed this Oct 7, 2024
@driskull driskull deleted the dris0000/panel-revert-relative-content branch October 7, 2024 23:42
@driskull driskull restored the dris0000/panel-revert-relative-content branch October 8, 2024 21:00
@driskull driskull reopened this Oct 8, 2024
@driskull
Copy link
Member Author

driskull commented Oct 8, 2024

The problem with reverting this is when you place a shell inside of a panel or dialog, it will go outside of the content because the position relative is not there.

If we revert, we would break this fix.

Shell is positioned absolutely by default which may be odd.

But it does seem like other elements shouldn't go outside of the panel content if positioned absolutely so the relative does make sense here.

@driskull driskull closed this Oct 8, 2024
@driskull driskull deleted the dris0000/panel-revert-relative-content branch October 8, 2024 21:19
@driskull driskull restored the dris0000/panel-revert-relative-content branch October 10, 2024 22:13
@driskull driskull reopened this Oct 10, 2024
@driskull driskull marked this pull request as ready for review October 10, 2024 22:25
@driskull driskull added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Oct 10, 2024
jcfranco
jcfranco approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Before merging, since this fixes a regression, can you use fix as the commit type, so it shows up in the changelog?

@driskull driskull added this to the 2.13.1 patch milestone Oct 10, 2024
@driskull driskull added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Oct 10, 2024
@jcfranco jcfranco mentioned this pull request Oct 10, 2024
Closed
6 tasks
@driskull driskull merged commit 239f4da into dev Oct 10, 2024
20 checks passed
@driskull driskull deleted the dris0000/panel-revert-relative-content branch October 10, 2024 22:45
@driskull driskull changed the title revert(panel): revert relative positioning on content fix(panel): revert relative positioning on content Oct 11, 2024
benelan pushed a commit that referenced this pull request Oct 11, 2024
@driskull @benelan
revert(panel): revert relative positioning on content (#10496)
4aa39b2 
**Related Issue:** #10494 #10095

## Summary

- reverts position relative styling
- #10119 should be verified again
@benelan benelan mentioned this pull request Oct 11, 2024
Merged
benelan pushed a commit that referenced this pull request Oct 11, 2024
@driskull @benelan
revert(panel): revert relative positioning on content (#10496)
e8cc258 
**Related Issue:** #10494 #10095

## Summary

- reverts position relative styling
- #10119 should be verified again
@benelan benelan mentioned this pull request Oct 11, 2024
Merged
benelan added a commit that referenced this pull request Oct 11, 2024
@calcite-admin @benelan
chore: release main (#10530)
6704555 
🤖 I have created a release *beep* *boop*
---


<details><summary>@esri/calcite-components: 2.13.1</summary>

##
[2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.13.0...@esri/calcite-components@2.13.1)
(2024-10-11)


### Bug Fixes

* **chip:** Fix close icon color inconsistency
([#10493](#10493))
([80b75c2](80b75c2))
* **combobox:** Restores `filterText` when filtered items are empty
([#10498](#10498))
([6667c2a](6667c2a))
* **dialog:** No longer apply transform styling unless dragEnabled or
resizable
([#10503](#10503))
([e93fdbc](e93fdbc))
* **notice:** Ensure closed notice does not affect layout
([#10518](#10518))
([655bbb7](655bbb7))
* **fix(panel):** Revert relative positioning on content
([#10496](#10496))
([239f4da](239f4da))
</details>

<details><summary>@esri/calcite-components-angular: 2.13.1</summary>

##
[2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.13.0...@esri/calcite-components-angular@2.13.1)
(2024-10-11)


### Miscellaneous Chores

* **@esri/calcite-components-angular:** Synchronize components versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 2.13.0 to 2.13.1
</details>

<details><summary>@esri/calcite-components-react: 2.13.1</summary>

##
[2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.13.0...@esri/calcite-components-react@2.13.1)
(2024-10-11)


### Miscellaneous Chores

* **@esri/calcite-components-react:** Synchronize components versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 2.13.0 to 2.13.1
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: Ben Elan <no-reply@benelan.dev>
benelan added a commit that referenced this pull request Oct 11, 2024
@calcite-admin @benelan
chore: release main (#10530)
922968b 
🤖 I have created a release *beep* *boop*
---

<details><summary>@esri/calcite-components: 2.13.1</summary>

[2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.13.0...@esri/calcite-components@2.13.1)
(2024-10-11)

* **chip:** Fix close icon color inconsistency
([#10493](#10493))
([80b75c2](80b75c2))
* **combobox:** Restores `filterText` when filtered items are empty
([#10498](#10498))
([6667c2a](6667c2a))
* **dialog:** No longer apply transform styling unless dragEnabled or
resizable
([#10503](#10503))
([e93fdbc](e93fdbc))
* **notice:** Ensure closed notice does not affect layout
([#10518](#10518))
([655bbb7](655bbb7))
* **fix(panel):** Revert relative positioning on content
([#10496](#10496))
([239f4da](239f4da))
</details>

<details><summary>@esri/calcite-components-angular: 2.13.1</summary>

[2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.13.0...@esri/calcite-components-angular@2.13.1)
(2024-10-11)

* **@esri/calcite-components-angular:** Synchronize components versions

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 2.13.0 to 2.13.1
</details>

<details><summary>@esri/calcite-components-react: 2.13.1</summary>

[2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.13.0...@esri/calcite-components-react@2.13.1)
(2024-10-11)

* **@esri/calcite-components-react:** Synchronize components versions

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 2.13.0 to 2.13.1
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: Ben Elan <no-reply@benelan.dev>
@benelan benelan mentioned this pull request Oct 11, 2024
Merged
benelan added a commit that referenced this pull request Oct 11, 2024
@benelan @calcite-admin
chore: release main (#10530)
3546253 
🤖 I have created a release *beep* *boop*
---

<details><summary>@esri/calcite-components: 2.13.1</summary>


[2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.13.0...@esri/calcite-components@2.13.1)
(2024-10-11)

* **chip:** Fix close icon color inconsistency
([#10493](#10493))

([80b75c2](80b75c2))
* **combobox:** Restores `filterText` when filtered items are empty
([#10498](#10498))

([6667c2a](6667c2a))
* **dialog:** No longer apply transform styling unless dragEnabled or
resizable
([#10503](#10503))

([e93fdbc](e93fdbc))
* **notice:** Ensure closed notice does not affect layout
([#10518](#10518))

([655bbb7](655bbb7))
* **fix(panel):** Revert relative positioning on content
([#10496](#10496))

([239f4da](239f4da))
</details>

<details><summary>@esri/calcite-components-angular: 2.13.1</summary>


[2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.13.0...@esri/calcite-components-angular@2.13.1)
(2024-10-11)

* **@esri/calcite-components-angular:** Synchronize components versions

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 2.13.0 to 2.13.1
</details>

<details><summary>@esri/calcite-components-react: 2.13.1</summary>


[2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.13.0...@esri/calcite-components-react@2.13.1)
(2024-10-11)

* **@esri/calcite-components-react:** Synchronize components versions

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 2.13.0 to 2.13.1
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See

[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: Calcite Admin <calcite-admin@esri.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcfranco jcfranco jcfranco approved these changes

Assignees

@driskull driskull

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. chore Issues with changes that don't modify src or test files. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
2.13.1 patch
Development

Successfully merging this pull request may close these issues.
2 participants
@driskull @jcfranco