Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(combobox): restores filterText when filtered items are empty #10498

Merged
merged 4 commits into from
Oct 10, 2024
Merged

fix(combobox): restores filterText when filtered items are empty #10498

merged 4 commits into from
Oct 10, 2024

Conversation

anveshmekala
Copy link
Contributor

Related Issue: #10156

Summary

Restores filterText when filtered items are empty.

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Oct 7, 2024
@anveshmekala anveshmekala added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Oct 8, 2024
@anveshmekala anveshmekala marked this pull request as ready for review October 8, 2024 18:07
@anveshmekala anveshmekala added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Oct 8, 2024
jcfranco
jcfranco approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! ✨🏆✨

packages/calcite-components/src/components/combobox/combobox.tsx
@@ -1633,7 +1633,7 @@ export class Combobox
class={{
[CSS.input]: true,
"input--single": true,
"input--hidden": showLabel,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨🏆✨

packages/calcite-components/src/components/combobox/combobox.e2e.ts Outdated Show resolved Hide resolved
packages/calcite-components/src/components/combobox/combobox.e2e.ts
await page.waitForChanges();
await combobox.type("an");
await page.waitForChanges();
await new Promise((res) => setTimeout(() => res(true), DEBOUNCE.filter));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency, can you use page.waitForTimeout for filtering delays?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

page.waitForTimeOut is deprecated.

@anveshmekala anveshmekala added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Oct 10, 2024
@anveshmekala anveshmekala merged commit 085eb23 into dev Oct 10, 2024
13 checks passed
@anveshmekala anveshmekala deleted the anveshmekala/10156-fix-combobox-close-on-filtering branch October 10, 2024 03:19
@github-actions github-actions bot added this to the 2.13.1 patch milestone Oct 10, 2024
benelan pushed a commit that referenced this pull request Oct 11, 2024
@anveshmekala @benelan
fix(combobox): restores filterText when filtered items are empty (#…
56cb787 
…10498)

**Related Issue:** #10156

## Summary

Restores `filterText` when filtered items are empty.
@benelan benelan mentioned this pull request Oct 11, 2024
Merged
benelan pushed a commit that referenced this pull request Oct 11, 2024
@anveshmekala @benelan
fix(combobox): restores filterText when filtered items are empty (#…
6667c2a 
…10498)

**Related Issue:** #10156

## Summary

Restores `filterText` when filtered items are empty.
This was referenced Oct 11, 2024
Closed
Merged
benelan added a commit that referenced this pull request Oct 11, 2024
@calcite-admin @benelan
chore: release main (#10530)
6704555 
🤖 I have created a release *beep* *boop*
---


<details><summary>@esri/calcite-components: 2.13.1</summary>

##
[2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.13.0...@esri/calcite-components@2.13.1)
(2024-10-11)


### Bug Fixes

* **chip:** Fix close icon color inconsistency
([#10493](#10493))
([80b75c2](80b75c2))
* **combobox:** Restores `filterText` when filtered items are empty
([#10498](#10498))
([6667c2a](6667c2a))
* **dialog:** No longer apply transform styling unless dragEnabled or
resizable
([#10503](#10503))
([e93fdbc](e93fdbc))
* **notice:** Ensure closed notice does not affect layout
([#10518](#10518))
([655bbb7](655bbb7))
* **fix(panel):** Revert relative positioning on content
([#10496](#10496))
([239f4da](239f4da))
</details>

<details><summary>@esri/calcite-components-angular: 2.13.1</summary>

##
[2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.13.0...@esri/calcite-components-angular@2.13.1)
(2024-10-11)


### Miscellaneous Chores

* **@esri/calcite-components-angular:** Synchronize components versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 2.13.0 to 2.13.1
</details>

<details><summary>@esri/calcite-components-react: 2.13.1</summary>

##
[2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.13.0...@esri/calcite-components-react@2.13.1)
(2024-10-11)


### Miscellaneous Chores

* **@esri/calcite-components-react:** Synchronize components versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 2.13.0 to 2.13.1
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: Ben Elan <no-reply@benelan.dev>
benelan added a commit that referenced this pull request Oct 11, 2024
@calcite-admin @benelan
chore: release main (#10530)
922968b 
🤖 I have created a release *beep* *boop*
---

<details><summary>@esri/calcite-components: 2.13.1</summary>

[2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.13.0...@esri/calcite-components@2.13.1)
(2024-10-11)

* **chip:** Fix close icon color inconsistency
([#10493](#10493))
([80b75c2](80b75c2))
* **combobox:** Restores `filterText` when filtered items are empty
([#10498](#10498))
([6667c2a](6667c2a))
* **dialog:** No longer apply transform styling unless dragEnabled or
resizable
([#10503](#10503))
([e93fdbc](e93fdbc))
* **notice:** Ensure closed notice does not affect layout
([#10518](#10518))
([655bbb7](655bbb7))
* **fix(panel):** Revert relative positioning on content
([#10496](#10496))
([239f4da](239f4da))
</details>

<details><summary>@esri/calcite-components-angular: 2.13.1</summary>

[2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.13.0...@esri/calcite-components-angular@2.13.1)
(2024-10-11)

* **@esri/calcite-components-angular:** Synchronize components versions

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 2.13.0 to 2.13.1
</details>

<details><summary>@esri/calcite-components-react: 2.13.1</summary>

[2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.13.0...@esri/calcite-components-react@2.13.1)
(2024-10-11)

* **@esri/calcite-components-react:** Synchronize components versions

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 2.13.0 to 2.13.1
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: Ben Elan <no-reply@benelan.dev>
@benelan benelan mentioned this pull request Oct 11, 2024
Merged
benelan added a commit that referenced this pull request Oct 11, 2024
@benelan @calcite-admin
chore: release main (#10530)
3546253 
🤖 I have created a release *beep* *boop*
---

<details><summary>@esri/calcite-components: 2.13.1</summary>


[2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.13.0...@esri/calcite-components@2.13.1)
(2024-10-11)

* **chip:** Fix close icon color inconsistency
([#10493](#10493))

([80b75c2](80b75c2))
* **combobox:** Restores `filterText` when filtered items are empty
([#10498](#10498))

([6667c2a](6667c2a))
* **dialog:** No longer apply transform styling unless dragEnabled or
resizable
([#10503](#10503))

([e93fdbc](e93fdbc))
* **notice:** Ensure closed notice does not affect layout
([#10518](#10518))

([655bbb7](655bbb7))
* **fix(panel):** Revert relative positioning on content
([#10496](#10496))

([239f4da](239f4da))
</details>

<details><summary>@esri/calcite-components-angular: 2.13.1</summary>


[2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.13.0...@esri/calcite-components-angular@2.13.1)
(2024-10-11)

* **@esri/calcite-components-angular:** Synchronize components versions

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 2.13.0 to 2.13.1
</details>

<details><summary>@esri/calcite-components-react: 2.13.1</summary>


[2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.13.0...@esri/calcite-components-react@2.13.1)
(2024-10-11)

* **@esri/calcite-components-react:** Synchronize components versions

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 2.13.0 to 2.13.1
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See

[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: Calcite Admin <calcite-admin@esri.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcfranco jcfranco jcfranco approved these changes

Assignees

@anveshmekala anveshmekala

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
2.13.1 patch
Development

Successfully merging this pull request may close these issues.
2 participants
@anveshmekala @jcfranco