Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(chip): fix close icon color inconsistency #10493

Merged
merged 1 commit into from
Oct 10, 2024
Merged

fix(chip): fix close icon color inconsistency #10493

merged 1 commit into from
Oct 10, 2024

Conversation

alisonailea
Copy link
Contributor

@alisonailea alisonailea commented Oct 7, 2024 •
edited
Loading

Related Issue: #10428

Summary

Mitigates the --calcite-chip-close-icon-color token inconsistency.
Screenshot 2024-10-07 at 9 20 41 AM

@alisonailea alisonailea requested a review from DitwanP October 7, 2024 16:19
@alisonailea alisonailea added p - high Issue should be addressed in the current milestone, impacts component or core functionality pr ready for visual snapshots Adding this label will run visual snapshot testing. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. and removed p - high Issue should be addressed in the current milestone, impacts component or core functionality labels Oct 7, 2024
@alisonailea alisonailea mentioned this pull request Oct 7, 2024
Open
@alisonailea alisonailea requested a review from driskull October 7, 2024 17:59
geospatialem
geospatialem reviewed Oct 7, 2024
View reviewed changes
Copy link
Member

@geospatialem geospatialem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the PR's commit message, could you alter the title to fit similar to the summary instead in alignment with our descriptive commit subject? In this case the PR title and the summary might need to flip the context.

Something like:

fix(chip): resolve component's close icon color inconsistency

Summary

Mitigates the --calcite-chip-close-icon-color token inconsistency.

Possibly consider more context that was mentioned in the linked issue to describe what the fix provides support to?

@DitwanP
Copy link
Contributor

DitwanP commented Oct 7, 2024 •
edited
Loading

Token verification: ✅
image
Looks like it's working as expected now, all close icons are showing the color that was set with token.

@alisonailea alisonailea changed the title fix(chip): —calcite-chip-close-icon-color fix(chip): resolve component's close icon color inconsistency Oct 8, 2024
jcfranco
jcfranco approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

driskull
driskull reviewed Oct 9, 2024
View reviewed changes
packages/calcite-components/.stylelintrc.cjs
"scale-duration",
"small-modular-scale"
];
const customFunctions = [];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcfranco this keeps happening for some reason 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I've noticed it in a few PRs, but haven't been able to reproduce locally. 😞

@jcfranco jcfranco changed the title fix(chip): resolve component's close icon color inconsistency fix(chip): fix close icon color inconsistency Oct 9, 2024
@geospatialem
Copy link
Member

@alisonailea Is the above good to merge for the upcoming patch? It looks like its been reviewed and all checks have passed

@alisonailea alisonailea merged commit e16f03b into dev Oct 10, 2024
29 checks passed
@alisonailea alisonailea deleted the astump/7180-chip-close-icon-color branch October 10, 2024 19:15
@github-actions github-actions bot added this to the 2.13.1 patch milestone Oct 10, 2024
@geospatialem geospatialem mentioned this pull request Oct 10, 2024
Closed
6 tasks
benelan pushed a commit that referenced this pull request Oct 11, 2024
@alisonailea @benelan
fix(chip): fix close icon color inconsistency (#10493)
b89164d 
**Related Issue:** #10428

## Summary

Mitigates the --calcite-chip-close-icon-color token inconsistency.
<img width="229" alt="Screenshot 2024-10-07 at 9 20 41 AM"
src="https://github.com/user-attachments/assets/ec410639-2767-4c01-8479-c2e24801884d">
@benelan benelan mentioned this pull request Oct 11, 2024
Merged
benelan pushed a commit that referenced this pull request Oct 11, 2024
@alisonailea @benelan
fix(chip): fix close icon color inconsistency (#10493)
80b75c2 
**Related Issue:** #10428

## Summary

Mitigates the --calcite-chip-close-icon-color token inconsistency.
<img width="229" alt="Screenshot 2024-10-07 at 9 20 41 AM"
src="https://github.com/user-attachments/assets/ec410639-2767-4c01-8479-c2e24801884d">
This was referenced Oct 11, 2024
Closed
Merged
benelan added a commit that referenced this pull request Oct 11, 2024
@calcite-admin @benelan
chore: release main (#10530)
6704555 
🤖 I have created a release *beep* *boop*
---


<details><summary>@esri/calcite-components: 2.13.1</summary>

##
[2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.13.0...@esri/calcite-components@2.13.1)
(2024-10-11)


### Bug Fixes

* **chip:** Fix close icon color inconsistency
([#10493](#10493))
([80b75c2](80b75c2))
* **combobox:** Restores `filterText` when filtered items are empty
([#10498](#10498))
([6667c2a](6667c2a))
* **dialog:** No longer apply transform styling unless dragEnabled or
resizable
([#10503](#10503))
([e93fdbc](e93fdbc))
* **notice:** Ensure closed notice does not affect layout
([#10518](#10518))
([655bbb7](655bbb7))
* **fix(panel):** Revert relative positioning on content
([#10496](#10496))
([239f4da](239f4da))
</details>

<details><summary>@esri/calcite-components-angular: 2.13.1</summary>

##
[2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.13.0...@esri/calcite-components-angular@2.13.1)
(2024-10-11)


### Miscellaneous Chores

* **@esri/calcite-components-angular:** Synchronize components versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 2.13.0 to 2.13.1
</details>

<details><summary>@esri/calcite-components-react: 2.13.1</summary>

##
[2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.13.0...@esri/calcite-components-react@2.13.1)
(2024-10-11)


### Miscellaneous Chores

* **@esri/calcite-components-react:** Synchronize components versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 2.13.0 to 2.13.1
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: Ben Elan <no-reply@benelan.dev>
benelan added a commit that referenced this pull request Oct 11, 2024
@calcite-admin @benelan
chore: release main (#10530)
922968b 
🤖 I have created a release *beep* *boop*
---

<details><summary>@esri/calcite-components: 2.13.1</summary>

[2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.13.0...@esri/calcite-components@2.13.1)
(2024-10-11)

* **chip:** Fix close icon color inconsistency
([#10493](#10493))
([80b75c2](80b75c2))
* **combobox:** Restores `filterText` when filtered items are empty
([#10498](#10498))
([6667c2a](6667c2a))
* **dialog:** No longer apply transform styling unless dragEnabled or
resizable
([#10503](#10503))
([e93fdbc](e93fdbc))
* **notice:** Ensure closed notice does not affect layout
([#10518](#10518))
([655bbb7](655bbb7))
* **fix(panel):** Revert relative positioning on content
([#10496](#10496))
([239f4da](239f4da))
</details>

<details><summary>@esri/calcite-components-angular: 2.13.1</summary>

[2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.13.0...@esri/calcite-components-angular@2.13.1)
(2024-10-11)

* **@esri/calcite-components-angular:** Synchronize components versions

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 2.13.0 to 2.13.1
</details>

<details><summary>@esri/calcite-components-react: 2.13.1</summary>

[2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.13.0...@esri/calcite-components-react@2.13.1)
(2024-10-11)

* **@esri/calcite-components-react:** Synchronize components versions

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 2.13.0 to 2.13.1
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: Ben Elan <no-reply@benelan.dev>
@benelan benelan mentioned this pull request Oct 11, 2024
Merged
benelan added a commit that referenced this pull request Oct 11, 2024
@benelan @calcite-admin
chore: release main (#10530)
3546253 
🤖 I have created a release *beep* *boop*
---

<details><summary>@esri/calcite-components: 2.13.1</summary>


[2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.13.0...@esri/calcite-components@2.13.1)
(2024-10-11)

* **chip:** Fix close icon color inconsistency
([#10493](#10493))

([80b75c2](80b75c2))
* **combobox:** Restores `filterText` when filtered items are empty
([#10498](#10498))

([6667c2a](6667c2a))
* **dialog:** No longer apply transform styling unless dragEnabled or
resizable
([#10503](#10503))

([e93fdbc](e93fdbc))
* **notice:** Ensure closed notice does not affect layout
([#10518](#10518))

([655bbb7](655bbb7))
* **fix(panel):** Revert relative positioning on content
([#10496](#10496))

([239f4da](239f4da))
</details>

<details><summary>@esri/calcite-components-angular: 2.13.1</summary>


[2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.13.0...@esri/calcite-components-angular@2.13.1)
(2024-10-11)

* **@esri/calcite-components-angular:** Synchronize components versions

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 2.13.0 to 2.13.1
</details>

<details><summary>@esri/calcite-components-react: 2.13.1</summary>


[2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.13.0...@esri/calcite-components-react@2.13.1)
(2024-10-11)

* **@esri/calcite-components-react:** Synchronize components versions

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 2.13.0 to 2.13.1
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See

[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: Calcite Admin <calcite-admin@esri.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geospatialem geospatialem geospatialem left review comments

@driskull driskull driskull left review comments

@jcfranco jcfranco jcfranco approved these changes

@DitwanP DitwanP Awaiting requested review from DitwanP

@benelan benelan Awaiting requested review from benelan benelan is a code owner

@macandcheese macandcheese Awaiting requested review from macandcheese

Assignees

@alisonailea alisonailea

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
2.13.1 patch
Development

Successfully merging this pull request may close these issues.
5 participants
@alisonailea @DitwanP @geospatialem @jcfranco @driskull