[PROF-11405] Revert "Temporary disable benchmark to make CI happy", second try #4461
+3
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…econd try **What does this PR do?** This reverts commit 569bf56. We had previously reverted that commit in #4376 but due to a bug had to undo all the heap profiling-related changes in #4409 . After #4460 gets merged, we can finally enable this benchmark again. **Motivation:** The benchmark was disabled for the reason mentioned in the comment. **Additional Notes:** I'm going to open this PR stacked on top of #4460, but this PR should only be merged after that other PR is merged to master. **How to test the change?** Validate this benchmark is now running in the benchmarking platform results page.
BenchmarksBenchmark execution time: 2025-03-05 15:56:10 Comparing candidate commit f7a92e6 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 32 metrics, 2 unstable metrics. scenario:tracing - Propagation - Datadog
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This reverts commit 569bf56.
We had previously reverted that commit in
#4376 but due to a bug had to undo all the heap profiling-related changes in #4409 .
After #4460 gets merged, we can finally enable this benchmark again.
Motivation:
The benchmark was disabled for the reason mentioned in the comment.
Change log entry
None.
Additional Notes:
I'm going to open this PR stacked on top of
#4460, but this PR should only be merged after that other PR is merged to master.
How to test the change?
Validate this benchmark is now running in the benchmarking platform results page.