[PROF-9476] Revert "Temporary disable benchmark to make CI happy" #4376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What does this PR do?** This reverts commit 569bf56. **Motivation:** We temporarily disabled this benchmark in #4331 for the reasons explained in the comment. Once that PR is in master we can re-enable the benchmark. **Additional Notes:** This sharp edge of our benchmarks setup is annoying, but I'll fight it another day... **How to test the change?** Validate this benchmark is now running in the benchmarking platform results page.
Datadog ReportBranch report: ✅ 0 Failed, 20589 Passed, 1463 Skipped, 3m 14.33s Total Time |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4376 +/- ##
==========================================
- Coverage 97.71% 97.70% -0.02%
==========================================
Files 1361 1361
Lines 83245 83239 -6
Branches 4226 4226
==========================================
- Hits 81344 81328 -16
- Misses 1901 1911 +10 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2025-02-18 13:48:09 Comparing candidate commit 9f5f5fa in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 33 metrics, 2 unstable metrics. |
Base automatically changed from
ivoanjo/prof-9476-managed-string-storage-try2
to
master
February 18, 2025 13:22
y9v
approved these changes
Feb 18, 2025
Strech
approved these changes
Feb 18, 2025
ivoanjo
added a commit
that referenced
this pull request
Mar 5, 2025
…econd try **What does this PR do?** This reverts commit 569bf56. We had previously reverted that commit in #4376 but due to a bug had to undo all the heap profiling-related changes in #4409 . After #4460 gets merged, we can finally enable this benchmark again. **Motivation:** The benchmark was disabled for the reason mentioned in the comment. **Additional Notes:** I'm going to open this PR stacked on top of #4460, but this PR should only be merged after that other PR is merged to master. **How to test the change?** Validate this benchmark is now running in the benchmarking platform results page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This reverts commit 569bf56.
Motivation:
We temporarily disabled this benchmark in
#4331
for the reasons explained in the comment.
Once that PR is in master we can re-enable the benchmark.
Change log entry
None.
Additional Notes:
This sharp edge of our benchmarks setup is annoying, but I'll fight it another day...
How to test the change?
Validate this benchmark is now running in the benchmarking platform results page.