-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PROF-11405] Graduate heap profiling from alpha to preview, second try #4460
base: master
Are you sure you want to change the base?
Conversation
…econd try **What does this PR do?** This reverts commit 569bf56. We had previously reverted that commit in #4376 but due to a bug had to undo all the heap profiling-related changes in #4409 . After #4460 gets merged, we can finally enable this benchmark again. **Motivation:** The benchmark was disabled for the reason mentioned in the comment. **Additional Notes:** I'm going to open this PR stacked on top of #4460, but this PR should only be merged after that other PR is merged to master. **How to test the change?** Validate this benchmark is now running in the benchmarking platform results page.
Datadog ReportBranch report: ❌ 1 Failed (0 Known Flaky), 19818 Passed, 1366 Skipped, 3m 16.53s Total Time ❌ Failed Tests (1)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏼
What does this PR do?
A few days ago, we merged #4331 and #4401 to master.
Starting with #4331, we used a new libdatadog feature for implementing the Ruby heap profiler. While validating these changes, we discovered this libdatadog feature had a bug (DataDog/libdatadog#896) and thus reverted all PRs related to this heap profiler change until we could get the fix in #4409.
Because the bug was only in the new libdatadog feature, it was still OK to use the old approach with the buggy libdatadog (since it used an alternative, non-buggy, code path).
Now that we have the fix on the libdatadog side almost ready, I'm opening this PR to re-apply the changes from #4331 and #4401 to master.
This PR is thus almost the reverse of the revert PR in #4409. The only difference is that it does not yet include the changes from #4376 for the same reason that PR was needed originally.
Motivation:
Release heap profiling feature.
Change log entry
Yes. Please use the one in #4401 .
Additional Notes:
There's quite a diff on this PR, but there's no differences to those earlier PRs other than adding a regression test for this issue (the regression test is a separate commit that can be reviewed by itself).
In fact, you may notice that CI is red for this PR because I'm opening it before the libdatadog fix is released. My intention is to exactly come back once the new libdatadog is released, and see this PR turn green with a simple merge from master.
How to test the change?
The earlier PRs already included tests; and I added a regression test for the libdatadog issue in this PR.