[PROF-11394] Revert changes to heap profiling in PRs #4401, #4376, #4331 #4409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lloeki
approved these changes
Feb 19, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4409 +/- ##
==========================================
- Coverage 97.71% 97.70% -0.01%
==========================================
Files 1366 1366
Lines 83397 83402 +5
Branches 4231 4231
==========================================
- Hits 81491 81490 -1
- Misses 1906 1912 +6 ☔ View full report in Codecov by Sentry. |
Datadog ReportBranch report: ✅ 0 Failed, 20607 Passed, 1372 Skipped, 3m 21.55s Total Time |
BenchmarksBenchmark execution time: 2025-02-19 14:15:52 Comparing candidate commit ded9fcb in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics. |
ivoanjo
added a commit
that referenced
this pull request
Mar 5, 2025
…econd try **What does this PR do?** This reverts commit 569bf56. We had previously reverted that commit in #4376 but due to a bug had to undo all the heap profiling-related changes in #4409 . After #4460 gets merged, we can finally enable this benchmark again. **Motivation:** The benchmark was disabled for the reason mentioned in the comment. **Additional Notes:** I'm going to open this PR stacked on top of #4460, but this PR should only be merged after that other PR is merged to master. **How to test the change?** Validate this benchmark is now running in the benchmarking platform results page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR reverts PRs #4401, #4376, #4331 which all relate to the heap profiling feature.
Motivation:
I'm doing this to unblock master for the next release, as we've detected this feature may be producing incorrect profiles in some situation.
I'm still investigating what's going on here.
Change log entry
None. Please remember not to include in the changelog entries related to heap profiling, as they've been reverted
Additional Notes:
N/A
How to test the change?
The diff is a bit weird, since these PRs touched a bunch of things. I've validated it myself in an easier way:
git diff v2.10.0 ext/ lib/datadog/profilingshows that no heap profiling changes are being shipped after this branch is applied.