Connatix auction viewability #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* New adapter: concepx * Syntax change * Revert syntax change * Defensive check for response from bidder server * Add better validation for the request * Merge branch 'master' of https://github.com/prebid/Prebid.js * Don't append url on every buildrequest * Add gvlId to conceptX * Update conceptxBidAdapter.js Defensice check * Update conceptxBidAdapter.js Reverse the check
* Update ttdBidAdapter.js * Update ttdBidAdapter.js * Update ttdBidAdapter.js * Update ttdBidAdapter.js * Update ttdBidAdapter.js * Update ttdBidAdapter_spec.js * Update ttdBidAdapter_spec.js * Update ttdBidAdapter.js * Update ttdBidAdapter.js * whitespace
Co-authored-by: dev <dev@adsrv.org>
…ces (prebid#12727) * Prebid Server adapter: fix bug with disabling some of multiple instances * Fix validation
…ge events for user ids (prebid#12704) * Fixed consent query params; Refactored post message events for eids * pr changes * update tests * refactor * renaming event * fix unit tests - size prop is not supported in all browsers
* Nodals AI RTD Module, implementation and tests * Move iteration over ad unit array to external library * Change production endpoint hostname * Add tests for override properties * Lint fixes * Updated endpoint response payload * Fix typo * Adjustment made to deps structure * Linting fix * Lint fix * Added missing documentation file * Change case of object reference * Updated variable names * Pass user consent object to library * Fix lint errors * Use Prebid utility to set page URL fact * Remove unrequired comment * Add the module to the allow list to request external Javascript * External script loading disclosure. * Remove unrequired log statement * Updated disclosure message * Linting --------- Co-authored-by: slimkrazy <sam@nodls.ai>
* r2b2 analytic adapter * fix import * fix lint errors * cache ttl, call depth, options warnings * callDepth doc comment * lint fix --------- Co-authored-by: jenda <jan.schotterl@r2b2.cz>
* Fix fake high entropy query * comment
…s included (prebid#12716) * 12238 - Azerion / Improve: does not properly support currency module * **Type:** Fix * **Scope:** improvedigitalBidAdapter * **Subject:** Bid floors are always converted to USD. * **Details:** * Adds `DEFAULT_CURRENCY` variable which is set to USD * Adds `convertBidFloorCurrency` function which in used to convert the bid floor when both `imp.bidfloor` and `imp.bidfloorcur` are present, and `imp.bidfloorcur` is not equal to the adapter's `DEFAULT_CURRENCY`; * **Breaks:** N/A * restored accidentally discarded change from unit test expect * * Modifies behavior to pass bid floor as is when it cannot be converted to USD; * Removes rounding of bid floor when converting its currency to USD; * remove unnecessary uses of `toUpperCase()` * * fix `convertCurrency` mock * remove redundant checks for type and NaN from `convertBidFloorCurrency` function * Restores the logic of choosing the winning bid for targeting inside getWinningBids instead of the using the hookable getHighestCpmBidsFromBidPool which has a logic to return bids unchanged, to sort them causing wrong targeting being applied when multibid module is included. * Adds unit test --------- Co-authored-by: Lyubomir Shishkov <l.shishkov@azerion.com> Co-authored-by: Jozef Bartek <31618107+jbartek25@users.noreply.github.com> Co-authored-by: Catalin Ciocov <catalin.ciocov@gmail.com>
…assing it to getAuction (prebid#12744) * Make auctionId an object field * Fix the test * Trigger test re-run
* ID5 EIDs from server side response * fix lint
* Add CondorX Bid Adapter * use inIframe utils function
* Add COPPA support to bidder user sync logic Extend `getUserSyncs` with a COPPA parameter for compliance purposes. This ensures the generated sync URLs handle COPPA requirements appropriately during user synchronization. * Add COPPA support to user sync tests and logic Incorporate COPPA handling into `getUserSyncs` function and related unit tests. Updated sync URL generation to include the COPPA parameter for compliance, ensuring proper configuration and testing across adapters.
…vice data (prebid#12721) * wurflRtdProvider: fix invalid types for pxratio and js in ORTB2 device data This commit corrects the data types for pixratio and js to match the requirements of the ORTB2 device specification. * wurflRtdProvider: apply linter suggestions
* added code for sending 'dspid' in tracker * added unit test cases for dspid in tracker * updated name from dspid to ds
* Core: mergedeep speedup uses direct assignment, loops over top level * Update utils.js * Update utils.js * linting
* Core: mild speedup on deepEqual a bit faster for arrays, also avoids repeated calls to Object.keys * Update utils.js * Update utils.js
* Mediago Bid Adapter : add param publisherid * Mediago Bid Adapter : add param publisherid * Mediago Bid Adapter : add param publisherid * Mediago Bid Adapter : add param publisherid * Mediago Bid Adapter : add param publisherid * Mediago Bid Adapter : add param publisherid * Mediago Bid Adapter : add param publisherid * Mediago Bid Adapter : add param publisherid * Mediago Bid Adapter : add param publisherid * Mediago Bid Adapter : add param publisherid * Mediago Bid Adapter : add param publisherid * Mediago Bid Adapter : add param publisherid * Mediago Bid Adapter : add param publisherid * Mediago Bid Adapter : add param publisherid * Mediago Bid Adapter : add param publisherid
…an 0 (prebid#12808) * add tagid, divid and allow video.api greater than 0 * add tagid, divid and allow video.api greater than 0
…id bid meta (prebid#12810) Co-authored-by: solodovnikov <o.i.solodovnikov@globallogic.com>
* overtoneRtdProvider and overtoneRtdProvider_spec * Added markdown * Updated overtoneRtdProvider.md with relevant changes * Update overtoneRtdProvider.md Updated markdown text for clarification * Update overtoneRtdProvider_spec.mjs Removed timeout and added additional tests * Modified for getBidRequestData test case --------- Co-authored-by: Subiksha <bikshaaa@gmail.com>
) * added impression level handling * Fixes after testing * Add changes related to setting publisher id , imp ext stored request id, tagid * SSI param removed * Imp tag id set only if available * test check added * test case running fine --------- Co-authored-by: Symplor <symplor.alpha@gmail.com> Co-authored-by: symplorpro <symplor.professional@gmail.com> Co-authored-by: symplorpro <161946060+symplorpro@users.noreply.github.com> Co-authored-by: symplor-alpha <112776856+symplor-alpha@users.noreply.github.com> Co-authored-by: Echo Symplor <symplor.echo@gmail.com> Co-authored-by: Charlie Symplor <symplor.charlie@gmail.com>
…rebid#12784) Co-authored-by: Stéphane Eintrazi <stephane.eintrazi@dailymotion.com>
* codepath notification workflow * adjusted paths * wordsmithing * Update send-notification-on-change.js --------- Co-authored-by: Patrick McCann <patmmccann@gmail.com>
…d` parameters. (prebid#12781) * feat(excoBidAdapter): Update * banner size validations * remove banner size validation * exco bid adapter update * exco bid adapter tests * exco bid adapter doc * update jsdocs * feat(): exco bid adapter - test alignment * feat(): ExcoBidAdapter, added warning message for deprecated prameters. * feat(): ExcoBidAdapter trigger e2e tests
…e withCredentials for requests (prebid#12819) * wip * chore: update ENDPOINT_URL * chore: update permission for localstorage * feat(bmsBidAdapter): implement bid floor logic and update request structure * test(bmsBidAdapter): remove commented-out tests for interpretResponse * wip * wip * Refactor geolocation implementationn * chore: minor adjustments * feat: add bidWon * update test * chore: Change double quotes to single quotes * Update creativeId and creative_id values * refactor: remove unused cookie ID handling from bid request * wip * Remove deprecated BMS sample HTML and update BMS bid adapter to use JSON.stringify for requests and sendBeacon for bid won notifications * wip * Update creative.html * Update creative.html * Update BMS bid adapter to use triggerPixel for bid won notifications and enable withCredentials for requests --------- Co-authored-by: Patrick McCann <pmccann@cafemedia.com>
* Stop using greedypromise * async tests: adxc, aso, blasto, criteo * async tests: improvedigital * use async * asyn tests: openx, pbs, pulsepoint * async tests: rubicon, silvermob, tpmn, trafficgate * async tests: userId * async tests: geolocation * async tests: auctions * refactor gpp * refactor tcf * wip: pbjs_api_spec * async tests: pbjs_api_spec * async tests: stragglers * async tests: passing * Use GreedyPromise instead of async * rename timeout to delay * Reinstate GreedyPromise as a library * async tests: pbjs_api * rename GreedyPromise to PbPromise * reset GPP data on each test * dupe checker fooled by whitespace? * Remove sync version of test utils * Fix cmUtils timeout bug * Extract consentManagement config parsing * Extract consent module config logic * fix greedy setTimeout * fix 8podAnalytics tests * Fix tests: userId * fix tests: escalax * Fix tests * Fix lint
prebid#12738) * AGT-389: CMP data to module * AGT-389: Analytics refactoring and changes after PR review * AGT-389: Parameters description, some edits * AGT-389: CMP data tests * AGT-389: Tests fix, export fpd * AGT-389: Fix uh parameter encoding * AGT-389: Refactoring, test for new user * fix linter * AGT-389: Minor fixes * AGT-389: Fix getIntentIqConfig method * AGT-389: Gdpr detected tests, fix gdpr requests addresses * AGT-389: Removed functionality partner to provide cmp data * AGT-389: Clear extra comments, fix test * AGT-389: Removed allow optons for cmpData * AFT-399: Change getCmpData * AFT-399: Change comment * AFT-399: Delete comment * gdprApplies, refactoring, fix tests * AGT-389: Refactoring storageUtils * AGT-389: Change version --------- Co-authored-by: DimaIntentIQ <dmytro.piskun@intentiq.com>
Co-authored-by: rishabhsehrawat1 <rishabh.s@z1tech.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3 to 4. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v3...v4) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* TargetVideo bid adapter * TargetVideo bid adapter * TargetVideo bid adapter * TargetVideo Bid Adapter: Add GDPR/USP support * TargetVideo Bid Adapter: Add GDPR/USP support tests * TargetVideo Bid Adapter: Updating margin rule * Add Brid bid adapter * Brid adapter requested changes * BridBidAdapter: switching to plcmt * Brid Bid Adapter: getUserSyncs method and interpretResponse updates * Adding missing semicolon * TargetVideo Bid Adapter : user sync and response changes * TargetVideo Bid Adapter : removing duplicate code * TargetVideo and Brid video adapters: fixing schain
* Re-add x-integration-type to TTD adapter * Revert x-integration-type (2nd time) due to flaky bidding behavior * Revert integration type header (2nd time) until we fix flaky bidding
* Support userSync feature * Added unit testing for userSync
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀 |
|
Tread carefully! This PR adds 2 linter errors (possibly disabled through directives):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.