Overtone RTD Module : initial release #12681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated markdown text for clarification
6 tasks
robertrmartinez
requested changes
Feb 6, 2025
| }; | ||
|
|
||
| describe('Overtone RTD Submodule with Test URLs', function () { | ||
| this.timeout(120000); |
There was a problem hiding this comment.
I do not think this is needed. Can you confirm / let me know why it is.
There was a problem hiding this comment.
Hello Robert, correct. This has now been removed.
| expect(data).to.deep.equal({ | ||
| categories: [], | ||
| status: 4, | ||
| }); |
There was a problem hiding this comment.
looks like just testing the fetchContextData function
would be useful to test the ortb2Fragments part of the getBidRequestData as well to cover more lines.
Removed timeout and added additional tests
robertrmartinez
approved these changes
Feb 27, 2025
kiho-shige
pushed a commit
to DAConsortium/Prebid.js
that referenced
this pull request
Mar 6, 2025
* overtoneRtdProvider and overtoneRtdProvider_spec * Added markdown * Updated overtoneRtdProvider.md with relevant changes * Update overtoneRtdProvider.md Updated markdown text for clarification * Update overtoneRtdProvider_spec.mjs Removed timeout and added additional tests * Modified for getBidRequestData test case --------- Co-authored-by: Subiksha <bikshaaa@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creation of overtoneRtdProvider RTD submodule, with markdown. Team contactable at tech@overtone.ai