Core: mild speedup on deepEqual #12717
Merged
+42
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a bit faster for arrays, also avoids repeated calls to Object.keys
|
Tread carefully! This PR adds 3 linter errors (possibly disabled through directives):
|
|
benchmarking in progress at https://github.com/bbaresic/util-bench |
|
speedup stats |
dgirardi
approved these changes
Feb 10, 2025
kiho-shige
pushed a commit
to DAConsortium/Prebid.js
that referenced
this pull request
Mar 6, 2025
* Core: mild speedup on deepEqual a bit faster for arrays, also avoids repeated calls to Object.keys * Update utils.js * Update utils.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor with the same behavior. A bit faster for arrays, also avoids repeated calls to Object.keys