Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EXCO Bid Adapter: Support of new publisherId, accountId and tagId parameters. #12781

Merged
merged 12 commits into from
Feb 28, 2025
Merged

EXCO Bid Adapter: Support of new publisherId, accountId and tagId parameters. #12781

merged 12 commits into from
Feb 28, 2025

Conversation

pb-pete
Copy link
Contributor

@pb-pete pb-pete commented Feb 18, 2025 •
edited
Loading

Type of change

  • Updated bidder adapter

Description of change

{
  bidder: 'exco',
  params: {
    cId: 'cId',                         // Legacy parameter
    pId: 'pId',                         // Legacy parameter
    accountId: 'EXCO Account ID',       // New EXCO parameter
    publisherId: 'EXCO Publisher ID',   // New EXCO parameter
    tagId: 'EXCO Tag ID',               // New EXCO parameter
    bidFloor: 0.0001,
    ext: {
      param1: 'loremipsum',
      param2: 'dolorsitamet'
    }
  }
}

Sorry, something went wrong.

pb-pete and others added 7 commits February 5, 2025 16:53
@pb-pete
feat(excoBidAdapter): Update

Verified

This commit was signed with the committer’s verified signature.
lukeholder Luke Holder
GPG key ID: 0904131B117BD05A
Verified
Learn about vigilant mode
01ee9cc
@pb-pete
banner size validations

Verified

This commit was signed with the committer’s verified signature.
lukeholder Luke Holder
GPG key ID: 0904131B117BD05A
Verified
Learn about vigilant mode
38cbb90
@pb-pete
remove banner size validation

Verified

This commit was signed with the committer’s verified signature.
lukeholder Luke Holder
GPG key ID: 0904131B117BD05A
Verified
Learn about vigilant mode
627cc03
@pb-pete
exco bid adapter update

Verified

This commit was signed with the committer’s verified signature.
lukeholder Luke Holder
GPG key ID: 0904131B117BD05A
Verified
Learn about vigilant mode
499432e
@pb-pete
exco bid adapter tests
d6e8e30
@pb-pete
exco bid adapter doc
8c8fc05
@pb-pete
Merge branch 'master' into exco-adapter/feature/update
d51922e
@github-actions GitHub Actions
Copy link

Tread carefully! This PR adds 10 linter warnings (possibly disabled through directives):

  • modules/excoBidAdapter.js (+10 warnings)

@pb-pete pb-pete changed the title Exco adapter/feature/update EXCO Bid Adapter: Update according to latest changes Feb 19, 2025
@patmmccann
Copy link
Collaborator

This is very cryptic. Did you end your relationship with Vidazoo?

@patmmccann patmmccann changed the title EXCO Bid Adapter: Update according to latest changes EXCO Bid Adapter: replace vidazoo imports Feb 19, 2025
@pb-pete pb-pete changed the title EXCO Bid Adapter: replace vidazoo imports EXCO Bid Adapter: support for new publisherid and account param format Feb 24, 2025
@pb-pete pb-pete changed the title EXCO Bid Adapter: support for new publisherid and account param format EXCO Bid Adapter: Support of new publisherId, accouuntId and tagId parameters. Feb 24, 2025
@pb-pete pb-pete changed the title EXCO Bid Adapter: Support of new publisherId, accouuntId and tagId parameters. EXCO Bid Adapter: Support of new publisherId, accountId and tagId parameters. Feb 24, 2025
@patmmccann patmmccann self-assigned this Feb 28, 2025
@patmmccann patmmccann merged commit 59467c0 into prebid:master Feb 28, 2025
5 checks passed
kiho-shige pushed a commit to DAConsortium/Prebid.js that referenced this pull request Mar 6, 2025
@pb-pete @kiho-shige
EXCO Bid Adapter: Support of new publisherId, accountId and `tagI…
e3f7b5c 
…d` parameters. (prebid#12781)

* feat(excoBidAdapter): Update

* banner size validations

* remove banner size validation

* exco bid adapter update

* exco bid adapter tests

* exco bid adapter doc

* update jsdocs

* feat(): exco bid adapter - test alignment

* feat(): ExcoBidAdapter, added warning message for deprecated prameters.

* feat(): ExcoBidAdapter trigger e2e tests
@pb-pete pb-pete mentioned this pull request Mar 6, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patmmccann patmmccann

Assignees

@patmmccann patmmccann

Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pb-pete @patmmccann