Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Design system implementation + MUI5 upgrade #494

Merged
merged 155 commits into from
Feb 14, 2023
Merged

New Design system implementation + MUI5 upgrade #494

merged 155 commits into from
Feb 14, 2023

Conversation

vmilan
Copy link
Contributor

@vmilan vmilan commented Oct 17, 2022 •
edited
Loading

Description

Shortcut: epic

Branch where we'll merge all changes until we merge in master for all users.

Upgrade guide

UPGRADE.md

Branches status

feature/design-system -> main branch

  • ⏸️ feature/storybook-v7 -> storybook version update to alpha 7
  • Basic setup:
    • ✅ feature/storybook-to-figma -> integration between Figma and Storybook
    • ✅ feature/storybook-structure -> Reorganization
    • ✅ feature/storybook-figma-lnks -> final Figma links in Storybook
  • Foundations:
    • ✅ feature/core-colors-palette
    • ✅ feature/core-typography
    • ✅ feature/update-foundations
    • ✅ feature/others-foundations (borders, shadows, and spacings)
    • ✅ feature/ds-foundations (breakpoints)
    • ✅ feature/typography-component -> New component to extend Mui Typography
  • MUI
    • ✅ feature/victor/mui-v5 -> update Material UI to v5 (C4R)
    • ✅ poc/victor/mui-v5 -> PoC (cloud-native)
    • C4R BREAKING CHANGES
      • ✅ feature/mui5-migration -> breaking changes in styles
      • ✅ feature/mui5-migration-components -> breaking changes in components
    • COMPONENTS
      • ✅ Vulture (feature/components-priority-1)
        • ✅ feature/components-priority-1-toggle
      • ✅ Walrus (feature/components-priority-2-1)
        • ✅ Radio and Checkbox
        • ✅ Switch
        • ✅ Tooltip
        • ✅ Tabs
      • ✅ Xenops
        • ✅ TextField
        • ✅ TextArea
        • ✅ Select
        • ✅ Upload field
        • ❌ Chips
        • ✅ Divider
      • ⏸️ Yak
        • ⏸️ Chips
        • ✅ AppBar

Changelog

  • Inputs size to small by default #556
  • New AppBar component (v1) and default props changes#555
  • New color variant in FAB button #554
  • Adjustments in theme to fix uses cases in cloud-native #553
  • Default props of core components to meet the common use case #552
  • Chip component adapted to the new design system #551
  • Design changes in UploadField component #548
  • Divider component adapted to the new design system #546
  • UploadField component created for the new design system #545
  • TextField and TextArea component adapted to the new design system #538
  • Tabs component adapted to the new design system #537
  • Tooltip component adapted to the new design system #536
  • Switch component adapted to the new design system #534
  • Design review of Toggle component #533
  • Radio and Checkbox components adapted to the new design system #532
  • Improvements in Components priority 1 after design review #529
  • Replace kebab-case properties in styles #530
  • New design system in priority 1 components #523
  • Breaking changes in Mui v5: components #518
  • Breaking changes in Mui v5: styles and theme #514
  • Add final Figma links into Storybook #515
  • Breaking changes in Mui v5: styles and theme #514
  • Breakpoints for the new design system #513
  • New Typography component to extend Mui Typography #506
  • New spacings, borders and shadows toolkit for MUI carto-theme #507
  • Colors and Typography: design update #502
  • Upgrade from Material UI v4 to MUI v5 #501
  • New typography toolkit for MUI carto-theme #498
  • New color palette for MUI carto-theme #496
  • Split carto-theme into sections #495
  • Integration between Figma and Storybook through addon-designs #488
  • Update Storybook to v6.5.12 #487

@vmilan vmilan added documentation Improvements or additions to documentation blocked labels Oct 17, 2022
@vmilan vmilan changed the title Design system experimental branch Design system implementation Oct 17, 2022
@coveralls
Copy link
Collaborator

coveralls commented Oct 17, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 4172820681

  • 56 of 65 (86.15%) changed or added relevant lines in 24 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 71.29%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/react-ui/src/assets/ArrowDropIcon.js 0 1 0.0%
packages/react-ui/src/theme/sections/components/navigation.js 1 2 50.0%
packages/react-ui/src/widgets/BarWidgetUI.js 1 2 50.0%
packages/react-ui/src/widgets/TimeSeriesWidgetUI/components/TimeSeriesChart.js 0 1 0.0%
packages/react-ui/src/widgets/comparative/ComparativeCategoryWidgetUI/CategoryItem.js 1 2 50.0%
packages/react-ui/src/theme/sections/components/buttons.js 7 9 77.78%
packages/react-ui/src/widgets/HistogramWidgetUI/HistogramWidgetUI.js 1 3 33.33%
Files with Coverage Reduction New Missed Lines %
packages/react-ui/src/widgets/BarWidgetUI.js 1 57.64%
Totals Coverage Status
Change from base Build 4138671575: -0.2%
Covered Lines: 1930
Relevant Lines: 2488
💛 - Coveralls

vmilan and others added 14 commits October 18, 2022 09:55
@vmilan
Split carto theme into sections (#495)
936a0db
@vmilan
New color palette of the design system (#497)
d56f379
@vmilan
New typography toolkit for MUI carto-theme (#498)
2640689
@VictorVelarde
Mui v5 upgrade (#501)
1773777 
* Add new mui-v5 packages + styled-components

* Add emotion react & styled libs deps

* Add automatic codemod replacements, mostly all import changes

* Partial and basic typing for new palette elements, using mui

* Fully remove material-ui v4 references from lib

* Fix import for createSpacing

* Remove material-ui externals from webpack configuration

* Adapt webpack externals with new peer deps, due to mui v5 upgrade

* Use custom render with providers in test files for react-ui

* Remove custom getMaterialUIContext in favour of render override for tests

* Fix LegendWidgetUI tests, due to some changes in the rendering details

* Fix FeatureSelectionWidgetUI tests, due to some changes in the rendering details

* Fix RangeWidgetUI tests by changing selectors  (temporarily?)

* Remove adaptV4Theme from Storybook preview

* Set a new alpha name for experimental release

* Mock requestAnimationFrame in FormulaUI tests

* v0.0.0-experimental-muiv5-0

* Set peer deps to experimental 0.0.0 packages

* v0.0.0-experimental-muiv5-1
@VictorVelarde
Run codemod link-underline-hover (#503)
050c714
@vmilan
Spacings, borders and shadows Foundations (#507)
5d8c2b3
@vmilan
Colors and Typography improvements (#502)
7a18d2f
@vmilan
New Typography component (#506)
3f26d2f
@VictorVelarde
Bump experimental version names, to be coordinated with official bran…
e688d18 
…ches
@VictorVelarde
v0.0.0-experimental-muiv5-1.5.0-alpha.4-0
3c9cf55
@VictorVelarde
Adjust peer deps to published
c12d5dd
@vmilan
Design System breakpoints and theme types (#513)
6973468
@VictorVelarde
v0.0.0-experimental-muiv5-1.5.0-alpha.4-1
8fa8cf1
@VictorVelarde
Bump peers with last prerelease
08602da
@VictorVelarde VictorVelarde changed the title Design system implementation New Design system implementation + MUI5 upgrade Jan 31, 2023
@VictorVelarde VictorVelarde self-requested a review February 14, 2023 09:57
VictorVelarde
VictorVelarde approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@VictorVelarde VictorVelarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vmilan vmilan removed do not merge! documentation Improvements or additions to documentation blocked labels Feb 14, 2023
@vmilan vmilan merged commit a468bfd into master Feb 14, 2023
@vmilan vmilan deleted the feature/design-system branch May 22, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VictorVelarde VictorVelarde VictorVelarde approved these changes

@aaranadev aaranadev Awaiting requested review from aaranadev

Assignees

@VictorVelarde VictorVelarde

@vmilan vmilan

Labels
design system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vmilan @coveralls @VictorVelarde