Spacings, borders and shadows Foundations #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| height: spacing(4.5), | ||
| width: spacing(4.5) | ||
| height: getSpacing(4.5), | ||
| width: getSpacing(4.5) |
There was a problem hiding this comment.
This is the type of 'strange' spacing numbers I was talking about... We should consider probably a rounding to the next 'accepted level'. I would suggest creating a new task to discuss with Design about it
There was a problem hiding this comment.
Here I just updated the function we use, not the value, but for sure we need to review every spacing we are using to adapt to the new ones that the design team defined. I was thinking of doing it when we start adapting each component.
| @@ -37,7 +37,7 @@ export const parameters = { | |||
| storySort: { | |||
| order: [ | |||
| 'Introduction', | |||
| 'CARTO Theme', | |||
| 'Atoms', | |||
There was a problem hiding this comment.
Let's validate tomorrow, but ok
|
This pull request has been linked to Shortcut Story #266310: CORE - Adapt others. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Shortcut: #266310
[sc-266310]
The rest of core elements beyond Colors / Typography: