Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration between Figma and Storybook #488

Merged
merged 16 commits into from
Oct 17, 2022
Merged

Integration between Figma and Storybook #488

merged 16 commits into from
Oct 17, 2022

Conversation

vmilan
Copy link
Contributor

@vmilan vmilan commented Oct 13, 2022

Description

Shortcut: not yet

Storybook's addon needed to embed Figma files within Storybook, and also a few stories already linked with Figma.

Type of change

  • Feature

@vmilan vmilan requested a review from a team October 13, 2022 17:00
@vmilan vmilan changed the title Integration Figma with Storybook Integration between Figma and Storybook Oct 13, 2022
@vmilan
Copy link
Contributor Author

vmilan commented Oct 14, 2022

@VictorVelarde I already removed the storybook log file. If you approve it, I could merge the branch

VictorVelarde
VictorVelarde reviewed Oct 17, 2022
View reviewed changes
Copy link
Contributor

@VictorVelarde VictorVelarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, but please add a note to CHANGELOG, so we can keep track of what's included here

VictorVelarde
VictorVelarde approved these changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@VictorVelarde VictorVelarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@vmilan vmilan merged commit 94423c3 into feature/design-system Oct 17, 2022
@vmilan vmilan deleted the feature/storybook-to-figma branch October 17, 2022 08:48
@vmilan vmilan mentioned this pull request Oct 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VictorVelarde VictorVelarde VictorVelarde approved these changes

Assignees
No one assigned
Labels
design system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmilan @VictorVelarde