New design system applied to priority 1 components #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #266115: COMPONENTS - Basic components (priority 1). |
| @@ -138,32 +137,32 @@ export const commonPalette = { | |||
| dark: baseColors.indigo[500], | |||
| light: baseColors.indigo[300], | |||
| contrastText: baseColors.common.white, | |||
| relatedDark: getMixedColor(baseColors.indigo[400], baseColors.neutral.A700, 0.6), | |||
| relatedLight: getMixedColor(baseColors.indigo[400], baseColors.common.white, 0.9) | |||
| relatedDark: '#0d2b4a', | |||
There was a problem hiding this comment.
nit, let's always try to keep uppercase
VictorVelarde
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Shortcut: #266115
[sc-266115]
Implement the new design system in priority 1 components. Toggle button will be in a different PR.
New Button component that uses Mui Button and wraps its children in Typography to meet with the designed behavior (text overflow case)
Also, stories and folders reorganization to meet the atomic design structure.