-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BHoM_Engine: Remove deprecated methods #3246
BHoM_Engine: Remove deprecated methods #3246
Conversation
@Tom-Kingstone to confirm, the following actions are now queued:
|
Please be advised that the check with reference 20487378506 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 3 additional annotations waiting, made up of 0 errors and 3 warnings. |
@BHoMBot check versioning |
@Tom-Kingstone to confirm, the following actions are now queued:
|
@BHoMBot check installer |
@Tom-Kingstone to confirm, the following actions are now queued:
|
@BHoMBot check installer |
@Tom-Kingstone to confirm, the following actions are now queued:
|
@BHoMBot check installer |
@Tom-Kingstone to confirm, the following actions are now queued:
|
@BHoMBot check versioning |
@Tom-Kingstone to confirm, the following actions are now queued:
|
@BHoMBot check versioning |
@Tom-Kingstone to confirm, the following actions are now queued:
|
@Tom-Kingstone to confirm, the following actions are now queued:
|
Please be advised that the check with reference 20501063442 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 3 additional annotations waiting, made up of 0 errors and 3 warnings. |
@Tom-Kingstone to confirm, the following actions are now queued:
There are 75 requests in the queue ahead of you. |
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: installer, unit-tests |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 20502085398 |
@FraserGreenroyd I have now provided a passing check on reference |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed the code and the deletions make sense, it's good to tidy these up so thanks @Tom-Kingstone !
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
|
NOTE: Depends on
Issues addressed by this PR
Closes #3243
Following methods marked
ToBeRemoved
have been removed:BH.Engine.Architecture.QueryNewElement1D(Room, ICurve)
BH.Engine.Diffing.Query.ListModifiedProperties(Dictionary<string, Dictionary<string, Tuple<object, object>>>)
BH.Engine.Environment.Create.CleanSpace(Panel)
BH.Engine.Environment.Query.FilterPanelsNotByType(Panel, PanelType)
BH.Engine.Geometry.Query.Centre(Polyline, double)
BH.Engine.Geometry.Query.Radius(Arc)
BH.Engine.Structure.Create.Panel(ICurve, List<Opening>, ISurfaceProperty, string)
BH.Engine.Structure.Create.Panel(List<Edge>, List<ICurve>, ISurfaceProperty, string)
BH.Engine.Structure.Create.AreaUniformlyDistributedLoad(Loadcase, Vector, BHoMGroup<IAreaElement>, LoadAxis, boolean, string)
BH.Engine.Structure.Create.BarUniformTemperatureLoad(Loadcase, double, BHoMGroup<Bar>, LoadAxis, boolean, string)
BH.Engine.Structure.Create.ContourLoad(Polyline, Vector, Loadcase, LoadAxis, boolean, string)
BH.Engine.Structure.Results.Create.MeshResult(MeshResultSmoothingType, MeshResultLayer, double, MeshResultType, Cartesian, IEnumerable<object>, IEnumerable<object>)
BH.Engine.Structure.Create.GeometricalLineLoad(Line, Loadcase, Vector, Vector, Vector, Vector, string)
And fixed cases where some deprecated methods were still being used in Structure_Engine
Test files
Changelog
Additional comments
If there are still unit tests for these methods, they will need to be removed as well.