Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align with removal of deprecated methods #186

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

Tom-Kingstone
Copy link
Contributor

NOTE: Depends on BHoM/BHoM_Engine#3246

Issues addressed by this PR

Fix usage of Panel Create()

Test files

Changelog

Additional comments

@Tom-Kingstone Tom-Kingstone added the type:compliance Non-conforming to code guidelines label Jan 15, 2024
@Tom-Kingstone Tom-Kingstone self-assigned this Jan 15, 2024
Copy link

bhombot-ci bot commented Jan 15, 2024

@Tom-Kingstone just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @Tom-Kingstone on BHoM_Engine

Copy link

bhombot-ci bot commented Jan 15, 2024

@Tom-Kingstone just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @Tom-Kingstone on BHoM_Engine

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check core
@BHoMBot check compliance

Copy link

bhombot-ci bot commented Jan 15, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check core
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 48 requests in the queue ahead of you.

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check null-handling
@BHoMBot check serialisation

Copy link

bhombot-ci bot commented Jan 15, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check null-handling
  • check serialisation

There are 92 requests in the queue ahead of you.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed by code and change made makes sense in the context and aligns with the changes to BHoM_Engine.

Copy link

bhombot-ci bot commented Jan 15, 2024

@Tom-Kingstone just to let you know, I have provided a check-ready-to-merge result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM_Engine

@FraserGreenroyd FraserGreenroyd merged commit 0c0d437 into develop Jan 15, 2024
12 checks passed
@FraserGreenroyd FraserGreenroyd deleted the BHoM_Engine-#3243-RemoveDeprecatedMethods branch January 15, 2024 17:47
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants