BHoM_Engine: Remove deprecated methods

Architecture_Engine/Versioning_71.json

@@ -0,0 +1,5 @@
+{
+  "MessageForDeleted": {
+    "BH.Engine.Architecture.Query.NewElement1D(BH.oM.Architecture.Elements.Room, BH.oM.Geometry.ICurve)": "NewElement methods were refactored in BHoM 3.2 with these methods marked for deletion, and have now been removed."
+  }
+}

Diffing_Engine/Versioning_71.json

@@ -0,0 +1,5 @@
+{
+  "MessageForDeleted": {
+    "BH.Engine.Diffing.Query.ListModifiedProperties(System.Collections.Generic.Dictionary<System.String, System.Collections.Generic.Dictionary<System.String, System.Tuple<System.Object, System.Object>>>, System.Collections.Generic.List<System.String>)": "This method has been deprecated since 5.0 due to the new Diffing object structure."
+  }
+}

Environment_Engine/Query/FilterPanels.cs

@@ -46,10 +46,10 @@
         /**** Public Methods                            ****/
         /***************************************************/
 
         [Description("Returns a collection of Environment Panels that match the given element ID")]
         [Input("panels", "A collection of Environment Panels")]
         [Input("elementID", "The Element ID to filter by")]
         [Output("panels", "A collection of Environment Panel objects that match the element ID")]
         public static List<Panel> FilterPanelsByElementID(this List<Panel> panels, string elementID)
         {
             List<IEnvironmentObject> envObjects = new List<IEnvironmentObject>();
@@ -67,20 +67,20 @@
             return rtnPanels;
         }
 
         [Description("Returns a collection of Environment Panels that match the given geometry")]
         [Input("panels", "A collection of Environment Panels")]
         [Input("searchGeometry", "The BHoM Geometry ICurve representation to search by")]
         [Output("panels", "A collection of Environment Panel where the external edges match the given search geometry")]
         public static List<Panel> FilterPanelsByGeometry(this List<Panel> panels, ICurve searchGeometry)
         {
             List<Point> searchPoints = searchGeometry.ICollapseToPolyline(BH.oM.Geometry.Tolerance.Angle).DiscontinuityPoints();
             return panels.Where(x => x.Polyline().DiscontinuityPoints().PointsMatch(searchPoints)).ToList();
         }
 
         [Description("Returns a collection of Environment Panels that sit entirely on a given levels elevation")]
         [Input("panels", "A collection of Environment Panels to filter")]
         [Input("searchLevel", "The Setting Out Level to search by")]
         [Output("panels", "A collection of Environment Panels which match the given level")]
         public static List<Panel> FilterPanelsByLevel(this List<Panel> panels, Level searchLevel)
         {
             if (panels == null)
@@ -98,19 +98,19 @@
             return panels.FilterPanelsByLevel(searchLevel.Elevation);
         }
 
         [Description("Returns a collection of Environment Panels that sit entirely on a given levels elevation")]
         [Input("panels", "A collection of Environment Panels to filter")]
         [Input("searchLevel", "The level to search by")]
         [Output("panels", "A collection of Environment Panels which match the given level")]
         public static List<Panel> FilterPanelsByLevel(this List<Panel> panels, double searchLevel)
         {
             return panels.Where(x => x.MinimumLevel() == searchLevel && x.MaximumLevel() == searchLevel).ToList();
         }
 
         [Description("Returns a collection of Environment Panels where the maximum level of the panel matches the elevation of the given search level")]
         [Input("panels", "A collection of Environment Panels to filter")]
         [Input("searchLevel", "The Setting Level to search by")]
         [Output("panels", "A collection of Environment Panels where the maximum level meets the search level")]
         public static List<Panel> FilterPanelsByMaximumLevel(this List<Panel> panels, Level searchLevel)
         {
             if (panels == null)
@@ -128,19 +128,19 @@
             return panels.FilterPanelsByMaximumLevel(searchLevel.Elevation);
         }
 
         [Description("Returns a collection of Environment Panels where the maximum level of the panel matches the elevation of the given search level")]
         [Input("panels", "A collection of Environment Panels to filter")]
         [Input("searchLevel", "The level to search by")]
         [Output("panels", "A collection of Environment Panels where the maximum level meets the search level")]
         public static List<Panel> FilterPanelsByMaximumLevel(this List<Panel> panels, double searchLevel)
         {
             return panels.Where(x => x.MaximumLevel() == searchLevel).ToList();
         }
 
         [Description("Returns a collection of Environment Panels where the minimum level of the panel matches the elevation of the given search level")]
         [Input("panels", "A collection of Environment Panels to filter")]
         [Input("searchLevel", "The Setting Out Level to search by")]
         [Output("panels", "A collection of Environment Panels where the minimum level meets the search level")]
         public static List<Panel> FilterPanelsByMinimumLevel(this List<Panel> panels, Level searchLevel)
         {
             if (panels == null)
@@ -158,58 +158,48 @@
             return panels.FilterPanelsByMinimumLevel(searchLevel.Elevation);
         }
 
         [Description("Returns a collection of Environment Panels where the minimum level of the panel matches the elevation of the given search level")]
         [Input("panels", "A collection of Environment Panels to filter")]
         [Input("searchLevel", "The level to search by")]
         [Output("panels", "A collection of Environment Panels where the minimum level meets the search level")]
         public static List<Panel> FilterPanelsByMinimumLevel(this List<Panel> panels, double searchLevel)
         {
             return panels.Where(x => x.MinimumLevel() == searchLevel).ToList();
         }
 
         [Description("Returns a collection of Environment Panels that are match the given name")]
         [Input("panels", "A collection of Environment Panels")]
         [Input("name", "The name of the panel to filter by")]
         [Output("panels", "A collection of Environment Panel that match the given name")]
         public static List<Panel> FilterPanelsByName(this List<Panel> panels, string name)
         {
             return panels.Where(x => x.Name == name).ToList();
         }
 
         [Description("Returns a collection of Environment Panels that are match the given tilt")]
         [Input("panels", "A collection of Environment Panels")]
         [Input("tilt", "The tilt to filter by")]
         [Output("panels", "A collection of Environment Panel that match the given tilt")]
         public static List<Panel> FilterPanelsByTilt(this List<Panel> panels, double tilt)
         {
             return panels.Where(x => x.Tilt() == tilt).ToList();
         }
 
         [Description("Returns a collection of Environment Panels that are tilted between the given tilt range")]
         [Input("panels", "A collection of Environment Panels")]
         [Input("minTilt", "The minimum tilt to filter by")]
         [Input("maxTilt", "The maximum tilt to filter by")]
         [Output("panels", "A collection of Environment Panel that are between the given tilt range")]
         public static List<Panel> FilterPanelsByTiltRange(this List<Panel> panels, double minTilt, double maxTilt)
         {
             return panels.Where(x => x.Tilt() >= minTilt && x.Tilt() <= maxTilt).ToList();
         }
 
-        [Description("Returns a collection of Environment Panels that DO NOT match a given Panel Type")]
-        [Input("panels", "A collection of Environment Panels")]
-        [Input("type", "A Panel Type to filter by from the Panel Type enum")]
-        [Output("panels", "A collection of Environment Panel that DO NOT match the given type")]
-        [ToBeRemoved("3.3", "Replaced by FilterPanelsByType which provides the panels which match and don't match a given type")]
-        public static List<Panel> FilterPanelsNotByType(this List<Panel> panels, PanelType type)
-        {
-            return panels.Where(x => x.Type != type).ToList();
-        }
-
         [Description("Returns a collection of Environment Panels that match the provided types as the first output, and the panels which don't match the provided types as the second output")]
         [Input("panels", "A collection of Environment Panels")]
         [Input("types", "One or more Panel Types to filter by from the Panel Type enum")]
         [MultiOutput(0, "panelsMatchingType", "A collection of Environment Panels that match the provided types")]
         [MultiOutput(1, "panelsNotMatchingType", "A collection of Environment Panel that DO NOT match the provided types")]
         [PreviousInputNames("types", "type")]
         public static Output<List<Panel>, List<Panel>> FilterPanelsByType(this List<Panel> panels, List<PanelType> types)
         {

Environment_Engine/Versioning_71.json

@@ -5,6 +5,8 @@
     "BH.Engine.Environment.Query.NewElement1D(BH.oM.Environment.Elements.Space, BH.oM.Geometry.ICurve)": "NewElement methods were refactored in BHoM 3.2 with these methods marked for deletion, and have now been removed.",
     "BH.Engine.Environment.Create.NewElement1D(BH.oM.Environment.Elements.Opening, BH.oM.Geometry.ICurve)": "NewElement methods were refactored in BHoM 3.2 with these methods marked for deletion, and have now been removed.",
     "BH.Engine.Environment.Create.NewElement1D(BH.oM.Environment.Elements.Panel, BH.oM.Geometry.ICurve)": "NewElement methods were refactored in BHoM 3.2 with these methods marked for deletion, and have now been removed.",
-    "BH.Engine.Environment.Create.NewInternalElement2D(BH.oM.Environment.Elements.Panel)": "NewElement methods were refactored in BHoM 3.2 with these methods marked for deletion, and have now been removed."
+    "BH.Engine.Environment.Create.NewInternalElement2D(BH.oM.Environment.Elements.Panel)": "NewElement methods were refactored in BHoM 3.2 with these methods marked for deletion, and have now been removed.",
+    "BH.Engine.Environment.Query.CleanSpace(System.Collections.Generic.List<BH.oM.Environment.Elements.Panel>)": "This method has been deprecated since 3.3, as it provided no meaningful output as the connected space attribute was not updated.",
+    "BH.Engine.Environment.Query.FilterPanelsNotByType(System.Collections.Generic.List<BH.oM.Environment.Elements.Panel>, BH.oM.Environment.Elements.PanelType)": "This method has been deprecated since 3.3, as its functionality has been captured by FilterPanelsByType which now outputs matched and unmatched panels."
   }
 }

Geometry_Engine/Query/Centre.cs

@@ -37,19 +37,6 @@ public static Point Centre(this Arc arc, double tolerance = Tolerance.Distance)
             return arc.CoordinateSystem.Origin;
         }
 
-        /***************************************************/
-
-        [ToBeRemoved("4.1", "To be removed as it is generally incorrect. Advising using Centroid instead.")]
-        public static Point Centre(this Polyline polyline, double tolerance = Tolerance.Distance)
-        {
-            //TODO: this is an average point, not centroid - should be distinguished
-
-            if (!polyline.IsClosed(tolerance))
-                return polyline.ControlPoints.Average(); // TODO: not true for a self-intersecting polyline?
-            else
-                return polyline.ControlPoints.GetRange(0, polyline.ControlPoints.Count - 1).Average();
-        }
-
         /***************************************************/
         /**** Surfaces                                    ****/
         /***************************************************/

Geometry_Engine/Versioning_71.json

@@ -0,0 +1,6 @@
+{
+  "MessageForDeleted": {
+    "BH.Engine.Geometry.Query.Centre(BH.oM.Geometry.Polyline, System.Double)": "This method has been deprecated since 4.1, as the method used was incorrect. If this method was used, please replace with the Centroid method instead",
+    "BH.Engine.Geometry.Query.Radius(BH.oM.Geometry.Arc)": "This method has been deprecated since 4.1, as Radius is now a public property of the Arc class"
+  }
+}

Structure_Engine/Convert/FEMeshToPanel.cs

@@ -72,7 +72,7 @@ public static List<Panel> FEMeshToPanel(this FEMesh feMesh)
             Panel panel = new Panel();
             foreach (Polyline polyline in polylines)
             {
-                panel = Create.Panel(polyline, null, null, feMesh.Name);
+                panel = Create.Panel(polyline, name:feMesh.Name);
                 if (feMesh.Property != null)
                 {
                     panel.Property = feMesh.Property;

Structure_Engine/Create/Elements/Panel.cs

@@ -151,28 +151,6 @@ public static Panel Panel(PlanarSurface surface, ISurfaceProperty property = nul
         }
 
         /***************************************************/
-        /**** Public Methods - ToBeRemoved               ****/
-        /***************************************************/
-
-        [ToBeRemoved("3.1", "Method that use a mixture of geometry and objects between edges and openings removed.")]
-        public static Panel Panel(List<Edge> externalEdges, List<ICurve> openings = null, ISurfaceProperty property = null, string name = "")
-        {
-            List<Opening> pOpenings = openings != null ? openings.Select(o => Create.Opening(o)).ToList() : new List<Opening>();
-            return Panel(externalEdges, pOpenings, property, null, name);
-        }
-
-        /***************************************************/
-
-        [ToBeRemoved("3.1", "Method that use a mixture of geometry and objects between edges and openings removed.")]
-        public static Panel Panel(ICurve outline, List<Opening> openings = null, ISurfaceProperty property = null, string name = "")
-        {
-            if (!outline.IIsClosed()) return null;
-            List<Edge> externalEdges = outline.ISubParts().Select(x => new Edge { Curve = x }).ToList();
-
-            return Panel(externalEdges, openings, property, null, name);
-        }
-
-        /***************************************************/
 
     }
 }