-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align with removal of deprecated methods #394
Align with removal of deprecated methods #394
Conversation
@Tom-Kingstone just to let you know, I have provided a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve by inspection.
@Tom-Kingstone just to let you know, I have provided a |
@Tom-Kingstone just to let you know, I have provided a |
@Tom-Kingstone to confirm, the following actions are now queued:
There are 9 requests in the queue ahead of you. |
@Tom-Kingstone to confirm, the following actions are now queued:
There are 79 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed by code and change made makes sense in the context and aligns with the changes to BHoM_Engine.
@Tom-Kingstone just to let you know, I have provided a |
NOTE: Depends on BHoM/BHoM_Engine#3246
Issues addressed by this PR
Removed unnecessary ICurve instantiation.
Test files
Changelog
Additional comments