Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.9.0 #3562

Merged
merged 106 commits into from
May 23, 2024
Merged

Release v1.9.0 #3562

merged 106 commits into from
May 23, 2024

Conversation

eanzhao
Copy link
Contributor

@eanzhao eanzhao commented May 23, 2024

See issue #3561

eanzhao and others added 20 commits May 21, 2024 12:15
…-Extension

Token symbol of MultiToken Contract will be case-insensitive
…lias

Update MultiToken Contract: Approve for all tokens and setting token alias
Store failed transaction result to database
Optimizing fee estimation calculation interface
Throw StateKeyOverSizeException if state key is too long
Copy link

vizipi bot commented May 23, 2024

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
86.21% EanCuznaivy 458 50
81.03% jason-hoopox 131 47
70.69% ZhangXin 133 41
58.62% gldeng 43 34
55.17% ssun0121 92 32
53.45% louis.li 64 31

Potential missing files from this Pull request

files commonly committed with a subset of this pr, but not committed this time. (click to collapse)
FilePercentilerate
...src/AElf.Kernel.SmartContract.ExecutionPluginForAcs1/FeeC50.00%1 out of 2 times

Committed file ranks

(click to expand)
  • 96.65%[...test/AElf.WebApp.Application.TestBase/WebAppTestAElfModul]
  • 88.55%[...src/AElf.WebApp.Application.Chain/Services/TransactionRes]
  • 88.55%[...src/AElf.CSharp.CodeOps/Validators/Whitelist/IWhitelistPr]
  • 86.18%[...test/AElf.Contracts.MultiToken.Tests/BVT/ACS2_TokenResour]
  • 67.84%[...src/AElf.Kernel.TransactionPool/Handler/TransactionValida]
  • 99.57%[contract/AElf.Contracts.MultiToken/TokenContract_Views.cs]
  • 86.18%[...test/AElf.Contracts.TestContract.Tests/PatchedContractSec]
  • 99.80%[...test/AElf.WebApp.Application.Chain.Tests/BlockChainAppSer]
  • 99.97%[protobuf/token_contract.proto]
  • 99.86%[contract/AElf.Contracts.Genesis/BasicContractZero.cs]
  • Copy link

    codecov bot commented May 23, 2024

    Codecov Report

    Attention: Patch coverage is 89.76035% with 47 lines in your changes are missing coverage. Please review.

    Project coverage is 90.70%. Comparing base (1842512) to head (a7c0637).

    Additional details and impacted files

    Impacted file tree graph

    @@           Coverage Diff            @@
    ##           master    #3562    +/-   ##
    ========================================
      Coverage   90.70%   90.70%            
    ========================================
      Files         663      668     +5     
      Lines       25543    25895   +352     
      Branches     2293     2325    +32     
    ========================================
    + Hits        23168    23489   +321     
    - Misses       2259     2290    +31     
      Partials      116      116            
    Files Coverage Δ
    ...ntract/AElf.Contracts.Genesis/BasicContractZero.cs 84.17% <100.00%> (+0.40%) ⬆️
    ...AElf.Contracts.Genesis/BasicContractZero_Helper.cs 97.06% <100.00%> (+0.04%) ⬆️
    ...MultiToken/TokenContract_ACS1_MethodFeeProvider.cs 95.29% <100.00%> (+0.11%) ⬆️
    ...ultiToken/TokenContract_ACS2_StatePathsProvider.cs 86.50% <100.00%> (+1.16%) ⬆️
    ...ct/AElf.Contracts.MultiToken/TokenContract_Fees.cs 94.08% <100.00%> (-0.01%) ⬇️
    ...lf.Contracts.MultiToken/TokenContract_NFTHelper.cs 100.00% <100.00%> (ø)
    ...Contracts.TokenConverter/TokenConverterContract.cs 99.67% <100.00%> (+0.36%) ⬆️
    ...CodeOps/Validators/Whitelist/IWhitelistProvider.cs 100.00% <100.00%> (ø)
    ...nel.CodeCheck/Application/CodeCheckJobProcessor.cs 100.00% <100.00%> (+11.11%) ⬆️
    ...deCheck/Application/CodeCheckValidationProvider.cs 60.00% <100.00%> (-2.50%) ⬇️
    ... and 19 more

    ... and 1 file with indirect coverage changes

    @JimAelf JimAelf merged commit 3806c18 into master May 23, 2024
    15 checks passed
    @delete-merged-branch delete-merged-branch bot deleted the release/1.9.0 branch May 23, 2024 08:59
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    6 participants