Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store failed transaction result to database #3557

Merged
merged 11 commits into from
May 21, 2024
Merged

Conversation

eanzhao
Copy link
Contributor

@eanzhao eanzhao commented May 17, 2024

  • Store failed / invalid transaction results to database
  • Test cases

Issue: #3556

Copy link

vizipi bot commented May 17, 2024

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
100.00% zecong.nian 15 11
72.73% EanCuznaivy 94 8
54.55% jason-hoopox 80 6
54.55% ZhangXin 64 6
36.36% 轩辕焮痕 2 4

Potential missing files from this Pull request

No commonly committed files found with a 40% threashold


Committed file ranks

(click to expand)
  • 41.20%[...src/AElf.Kernel.Core/Blockchain/Domain/IInvalidTransactio]
  • 99.37%[src/AElf.Launcher/appsettings.json]
  • 67.85%[...src/AElf.WebApp.Application.Chain/Services/TransactionRes]
  • 98.41%[protobuf/aelf/core.proto]
  • 51.72%[...src/AElf.Kernel.TransactionPool/Application/IInvalidTrans]
  • 96.65%[...test/AElf.WebApp.Application.TestBase/WebAppTestAElfModul]
  • 88.55%[...src/AElf.WebApp.Application.Chain/Services/TransactionRes]
  • 99.80%[...test/AElf.WebApp.Application.Chain.Tests/BlockChainAppSer]
  • 67.85%[...src/AElf.Kernel.TransactionPool/Handler/TransactionValida]
  • 97.81%[src/AElf.Kernel.Core/CoreKernelAElfModule.cs]
  • @vizipi vizipi bot requested review from jason-aelf, zhxymh and hzz780 May 17, 2024 12:04
    Copy link

    codecov bot commented May 17, 2024

    Codecov Report

    Attention: Patch coverage is 93.33333% with 2 lines in your changes are missing coverage. Please review.

    Project coverage is 90.73%. Comparing base (0d78fc6) to head (eb9aac5).

    Additional details and impacted files

    Impacted file tree graph

    @@           Coverage Diff           @@
    ##              dev    #3557   +/-   ##
    =======================================
      Coverage   90.73%   90.73%           
    =======================================
      Files         665      668    +3     
      Lines       25832    25860   +28     
      Branches     2322     2323    +1     
    =======================================
    + Hits        23439    23465   +26     
    - Misses       2277     2279    +2     
      Partials      116      116           
    Files Coverage Δ
    ...ckchain/Domain/IInvalidTransactionResultManager.cs 100.00% <100.00%> (ø)
    src/AElf.Kernel.Core/CoreKernelAElfModule.cs 100.00% <100.00%> (ø)
    ...ol/Application/IInvalidTransactionResultService.cs 100.00% <100.00%> (ø)
    .../AElf.Kernel.TransactionPool/TransactionOptions.cs 100.00% <ø> (ø)
    ...tion.Chain/Services/TransactionResultAppService.cs 100.00% <100.00%> (ø)
    ...on.Chain/Services/TransactionResultProxyService.cs 100.00% <100.00%> (ø)
    ...r/TransactionValidationStatusFailedEventHandler.cs 88.23% <88.23%> (ø)

    @vizipi vizipi bot requested review from jason-aelf and zhxymh May 21, 2024 02:58
    @eanzhao eanzhao merged commit c2f2e7f into dev May 21, 2024
    13 checks passed
    @delete-merged-branch delete-merged-branch bot deleted the feature/invalid-tx-result branch May 21, 2024 10:32
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    5 participants