Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw StateKeyOverSizeException if state key is too long #3560

Merged
merged 4 commits into from
May 21, 2024

Conversation

eanzhao
Copy link
Contributor

@eanzhao eanzhao commented May 20, 2024

Issue: #3559

Copy link

vizipi bot commented May 20, 2024

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
100.00% EanCuznaivy 36 4
100.00% jason-hoopox 13 4
75.00% gldeng 9 3
50.00% ssun0121 17 2
50.00% ZhangXin 11 2
50.00% kaiwenzhengaelf 8 2

Potential missing files from this Pull request

files commonly committed with a subset of this pr, but not committed this time. (click to collapse)
FilePercentilerate
src/AElf.Sdk.CSharp/CSharpSmartContractContext.cs75.00%3 out of 4 times
test/AElf.CSharp.CodeOps.Tests/ContractAuditorTests.cs75.00%3 out of 4 times
...src/AElf.CSharp.CodeOps/Patchers/Module/ExecutionObserver75.00%3 out of 4 times
...src/AElf.CSharp.CodeOps/Validators/Module/ObserverProxyVa75.00%3 out of 4 times
test/AElf.Contracts.TestBase/ContractTester.cs50.00%2 out of 4 times
AElf.sln50.00%2 out of 4 times
protobuf/token_contract.proto50.00%2 out of 4 times
src/AElf.Runtime.CSharp/Executive.cs50.00%2 out of 4 times
src/AElf.Runtime.CSharp/CSharpSmartContractProxy.cs50.00%2 out of 4 times
src/AElf.CSharp.CodeOps/Extensions.cs50.00%2 out of 4 times

Committed file ranks

(click to expand)
  • 86.18%[...test/AElf.Contracts.TestContract.Tests/PatchedContractSec]
  • 90.80%[src/AElf.Kernel.SmartContract/SmartContractConstants.cs]
  • 97.58%[...src/AElf.Kernel.SmartContract.Shared/ISmartContractBridge]
  • 99.57%[...src/AElf.Kernel.SmartContract/HostSmartContractBridgeCont]
  • Copy link

    codecov bot commented May 20, 2024

    Codecov Report

    Attention: Patch coverage is 25.00000% with 9 lines in your changes are missing coverage. Please review.

    Project coverage is 90.70%. Comparing base (9ff35c0) to head (2b1cde6).

    Additional details and impacted files

    Impacted file tree graph

    @@            Coverage Diff             @@
    ##              dev    #3560      +/-   ##
    ==========================================
    - Coverage   90.73%   90.70%   -0.04%     
    ==========================================
      Files         668      668              
      Lines       25883    25895      +12     
      Branches     2325     2325              
    ==========================================
    + Hits        23486    23489       +3     
    - Misses       2281     2290       +9     
      Partials      116      116              
    Files Coverage Δ
    ...el.SmartContract/HostSmartContractBridgeContext.cs 92.39% <ø> (ø)
    ...martContract.Shared/ISmartContractBridgeContext.cs 65.00% <25.00%> (-10.00%) ⬇️

    @vizipi vizipi bot requested a review from jason-aelf May 21, 2024 13:54
    @eanzhao eanzhao merged commit c74f23e into dev May 21, 2024
    13 checks passed
    @delete-merged-branch delete-merged-branch bot deleted the feature/state-key-length-limit branch May 21, 2024 15:43
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants