Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token symbol of MultiToken Contract will be case-insensitive #3548

Merged
merged 12 commits into from
May 21, 2024

Conversation

eanzhao
Copy link
Contributor

@eanzhao eanzhao commented May 17, 2024

  • Add Regex to code check whitelist
  • Now we use InsensitiveTokenExisting state to determine if a token exists

Issue: #3547

Copy link

vizipi bot commented May 17, 2024

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
90.91% EanCuznaivy 213 10
90.91% louis.li 49 10
90.91% jason-hoopox 16 10
90.91% gldeng 8 10
72.73% ZhangXin 12 8
72.73% zhifenglee-portkey 6 8

Potential missing files from this Pull request

files commonly committed with a subset of this pr, but not committed this time. (click to collapse)
FilePercentilerate
...test/AElf.Kernel.SmartContract.ExecutionPluginForAcs1.Tes66.67%12 out of 18 times
...src/AElf.Kernel.SmartContract.ExecutionPluginForAcs1/FeeC66.67%12 out of 18 times
...contract/AElf.Contracts.MultiToken/TokenContract_Method_A50.00%1 out of 2 times
...src/AElf.Kernel.TransactionPool/TransactionPoolAElfModule50.00%1 out of 2 times

Committed file ranks

(click to expand)
  • 99.72%[contract/AElf.Contracts.MultiToken/TokenContract_Helper.cs]
  • 0.00%[...test/AElf.Contracts.MultiToken.Tests/BVT/SymbolValidation]
  • 90.31%[...contract/AElf.Contracts.MultiToken/TokenContract_NFTHelpe]
  • 97.90%[...contract/AElf.Contracts.MultiToken/TokenContract_NFT_Acti]
  • 99.98%[contract/AElf.Contracts.MultiToken/TokenContract_Actions.cs]
  • 94.40%[...test/AElf.Contracts.MultiToken.Tests/BVT/NftApplicationTe]
  • 99.44%[contract/AElf.Contracts.MultiToken/TokenContractState.cs]
  • 87.85%[...test/AElf.Contracts.TokenConverter.Tests/TokenConvertConn]
  • 99.29%[...contract/AElf.Contracts.TokenConverter/TokenConverterCont]
  • 87.85%[...src/AElf.CSharp.CodeOps/Validators/Whitelist/IWhitelistPr]
  • Copy link

    vizipi bot commented May 17, 2024

    Pull request analysis by VIZIPI

    Below you will find who is the most qualified team member to review your code.
    This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

    Reviewers with knowledge related to these changes

    Match % Person Commit Count Common Files
    100.00% EanCuznaivy 213 10
    100.00% louis.li 49 10
    100.00% jason-hoopox 16 10
    100.00% gldeng 8 10
    80.00% ZhangXin 12 8
    80.00% zhifenglee-portkey 6 8

    Potential missing files from this Pull request

    files commonly committed with a subset of this pr, but not committed this time. (click to collapse)
    FilePercentilerate
    ...test/AElf.Kernel.SmartContract.ExecutionPluginForAcs1.Tes66.67%12 out of 18 times
    ...src/AElf.Kernel.SmartContract.ExecutionPluginForAcs1/FeeC66.67%12 out of 18 times
    ...contract/AElf.Contracts.MultiToken/TokenContract_Method_A50.00%1 out of 2 times
    ...src/AElf.Kernel.TransactionPool/TransactionPoolAElfModule50.00%1 out of 2 times
    ...contract/AElf.Contracts.TokenConverter/TokenConvert_Views50.00%1 out of 2 times

    Committed file ranks

    (click to expand)
  • 97.85%[...contract/AElf.Contracts.MultiToken/TokenContract_NFT_Acti]
  • 87.85%[...test/AElf.Contracts.TokenConverter.Tests/TokenConvertConn]
  • 99.70%[contract/AElf.Contracts.MultiToken/TokenContract_Helper.cs]
  • 99.29%[...contract/AElf.Contracts.TokenConverter/TokenConverterCont]
  • 99.44%[contract/AElf.Contracts.MultiToken/TokenContractState.cs]
  • 94.20%[...test/AElf.Contracts.MultiToken.Tests/BVT/NftApplicationTe]
  • 99.98%[contract/AElf.Contracts.MultiToken/TokenContract_Actions.cs]
  • 87.85%[...src/AElf.CSharp.CodeOps/Validators/Whitelist/IWhitelistPr]
  • 89.80%[...contract/AElf.Contracts.MultiToken/TokenContract_NFTHelpe]
  • 98.47%[...test/AElf.Contracts.TokenConverter.Tests/TokenConverterCo]
  • Copy link

    codecov bot commented May 17, 2024

    Codecov Report

    Attention: Patch coverage is 92.59259% with 2 lines in your changes are missing coverage. Please review.

    Project coverage is 90.69%. Comparing base (e176826) to head (01d9c25).

    Additional details and impacted files

    Impacted file tree graph

    @@            Coverage Diff             @@
    ##              dev    #3548      +/-   ##
    ==========================================
    + Coverage   90.68%   90.69%   +0.01%     
    ==========================================
      Files         665      665              
      Lines       25570    25582      +12     
      Branches     2295     2291       -4     
    ==========================================
    + Hits        23188    23202      +14     
    + Misses       2266     2264       -2     
      Partials      116      116              
    Files Coverage Δ
    ...AElf.Contracts.MultiToken/TokenContract_Actions.cs 95.84% <100.00%> (ø)
    ...lf.Contracts.MultiToken/TokenContract_NFTHelper.cs 100.00% <100.00%> (ø)
    ...Contracts.TokenConverter/TokenConverterContract.cs 99.65% <100.00%> (+0.34%) ⬆️
    ...CodeOps/Validators/Whitelist/IWhitelistProvider.cs 100.00% <100.00%> (ø)
    .../AElf.Contracts.MultiToken/TokenContract_Helper.cs 84.40% <87.50%> (+0.46%) ⬆️
    ....Contracts.MultiToken/TokenContract_NFT_Actions.cs 89.28% <66.66%> (ø)

    @vizipi vizipi bot requested a review from jason-aelf May 20, 2024 03:07
    @eanzhao eanzhao merged commit 2d10a3b into dev May 21, 2024
    13 checks passed
    @delete-merged-branch delete-merged-branch bot deleted the feature/token-symbol-format-Extension branch May 21, 2024 05:58
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants