Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkin pending Discovering Rooms features spec #62

Merged

Conversation

user512
Copy link
Contributor

@user512 user512 commented Aug 2, 2020

Connects: #39
Checking this in while working on discovering rooms feature so we don't forget.

@user512 user512 requested a review from zspencer August 2, 2020 17:37
Copy link
Member

@zspencer zspencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I think one other thing to consider is back-linking to the Github Issue that includes the feature definition so that people can find the historical context.

@@ -0,0 +1,39 @@
@wip
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'd prefer we use @wip on scenarios for the work that is actually in flight; and maybe use @unstarted for the scenarios that have not yet been picked up. We can use @unscheduled for feature definitions that we are contemplating but have not yet decided which release they go in to.

We'll probably also want to add and not @unstarted to the test script in package.json

Now that Tom has removed Unlisted Rooms from the Workspace show page, I
have updated the feature file to indicate which scenarios work but are
missing functional step definitions.

See: #39
See: #60
@zspencer zspencer changed the base branch from development to member-only-see-listed-room August 3, 2020 01:10
@zspencer zspencer merged commit 454dc7e into member-only-see-listed-room Aug 3, 2020
@zspencer zspencer deleted the checkin-discover-rooms-feature-spec branch August 3, 2020 01:12
zspencer added a commit that referenced this pull request Aug 3, 2020
* Feature tests for Discovering Rooms (#62)

See: #39
See: #60

Co-authored-by: Zee <50284+zspencer@users.noreply.github.com>

* Test the Room `listed` scope

Co-authored-by: Zee <50284+zspencer@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants