Member only see listed rooms #60
Conversation
convene-web/Gemfile.lock
Outdated
| @@ -37,6 +37,8 @@ GEM | |||
| erubi (~> 1.4) | |||
| rails-dom-testing (~> 2.0) | |||
| rails-html-sanitizer (~> 1.1, >= 1.2.0) | |||
| active_record_union (1.3.0) | |||
There was a problem hiding this comment.
The README indicates that for folks using PostgreSQL, there is a more potent toolkit called ActiveRecordExtended.
This may give us more super-powers for the future; thoughts on using that instead of the one that just adds Union?
There was a problem hiding this comment.
Nice, didn't know about this tool.
| @@ -9,7 +9,7 @@ | |||
|
|
|||
| <div class="p-6"> | |||
| <ul class="mt-3 grid grid-cols-1 gap-5 sm:gap-6 sm:grid-cols-2 lg:grid-cols-4"> | |||
| <% @workspace.rooms.each do |room| %> | |||
| <% @workspace.rooms.accessable_by.each do |room| %> | |||
There was a problem hiding this comment.
I think we still want to pass in current_user even if we're not using it for anything and it's a nil value. That way when we do start implementing users we don't have to find and update usages of accessable by.
Thoughts?
There was a problem hiding this comment.
Right, but I believe we don't have current_user yet.
There was a problem hiding this comment.
We could add a helper_method def current_user; nil; end to ApplicationController as a seam if we want.
* Hold off from implementing accessable_by because we now treat every guest as members
38dbfa1 to
3f68d60
Compare
Part of #39
Hold off from implementing
accessable_bybecause we now treat every guest as members