Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discovering Rooms #39

Closed
5 tasks done
user512 opened this issue Jul 3, 2020 · 2 comments
Closed
5 tasks done

Discovering Rooms #39

user512 opened this issue Jul 3, 2020 · 2 comments
Labels
⛰️ epic Work we expect will take multiple patches to complete ✨ feature Reduces Client's Burden or Grants them Benefits

Comments

@user512
Copy link
Contributor

user512 commented Jul 3, 2020 •
edited by zspencer
Loading

This Issue May Be Closed When

  • Workspace Members may discover listed rooms
  • Workspace Members cannot discover unlisted rooms
  • The feature definition is in the repository
  • The step definitions are wired in
  • There is a tutorial for entering rooms somewhere under https://www.zinc.coop/convene/ We can do this later.

Feature Definition

Feature: In order to interact with other people in a Workspace
         I want to be able to explore the Workspace's rooms  

Scenario: Workspace Member may discover Listed Room
  Given a Workspace with a Listed Room
  When a Workspace Member is on the Workspace Dashboard
  Then they see the Room

Scenario: Workspace Member may not discover Unlisted Room
  Given a Workspace with an Unlisted Room
  When a Workspace Member is on the Workspace Dashboard
  Then they do not see the Room

Scenario: Guest may discover Listed Room
  Given a Workspace with a Listed Room
  When a Guest is on the Workspace Dashboard
  Then they see the Room

Scenario: Guest may not discover Unlisted Room
  Given a Workspace with an Unlisted Room
  When a Guest is on the Workspace Dashboard
  Then they do not see the Room

UI Mockup

Convene - Discovering Rooms - UI Sketch
@user512 user512 added this to the 1.0 - Andromeda milestone Jul 3, 2020
@user512 user512 changed the title Workspace Member may access Unlocked Internal Room Discovering rooms Jul 3, 2020
@user512 user512 changed the title Discovering rooms Discovering Rooms Jul 3, 2020
@user512 user512 added security ✨ feature Reduces Client's Burden or Grants them Benefits ⛰️ epic Work we expect will take multiple patches to complete and removed research labels Jul 3, 2020
This was referenced Aug 2, 2020
Merged
Merged
zspencer added a commit that referenced this issue Aug 3, 2020
@zspencer
Discovering Rooms feature file reflects state of system
cfbb4e4 
Now that Tom has removed Unlisted Rooms from the Workspace show page, I
have updated the feature file to indicate which scenarios work but are
missing functional step definitions.

See: #39
See: #60
zspencer added a commit that referenced this issue Aug 3, 2020
@user512 @zspencer
Feature tests for Discovering Rooms (#62)
454dc7e 
See: #39
See: #60

Co-authored-by: Zee <50284+zspencer@users.noreply.github.com>
zspencer added a commit that referenced this issue Aug 3, 2020
@user512 @zspencer
Workspace Occupants only see Listed rooms (#60)
6b5ef5d 
* Feature tests for Discovering Rooms (#62)

See: #39
See: #60

Co-authored-by: Zee <50284+zspencer@users.noreply.github.com>

* Test the Room `listed` scope

Co-authored-by: Zee <50284+zspencer@users.noreply.github.com>
@zspencer zspencer mentioned this issue Aug 3, 2020
Closed
6 tasks
@zspencer
Copy link
Member

zspencer commented Aug 3, 2020

I've pulled out:

As I believe this particular feature is reaching "useful enough" to consider moving it into the "how do we present this to the world as part of our marketing and education efforts" stage of development.

@melissamcewen - Would you be interested in taking point on that? I don't think we want to tie in too much visuals since I expect the UI will evolve over the next few months; but the concept of "you can navigate between rooms to gather in a self-determining manner" may be worth highlighting on a sub-page or something? What do you think?

@user512 user512 mentioned this issue Aug 3, 2020
Merged
4 tasks
@zspencer zspencer mentioned this issue Aug 11, 2020
Closed
@zspencer zspencer added test and removed test labels Aug 23, 2020
zspencer added a commit that referenced this issue Aug 23, 2020
@zspencer
Wire in scenarios for guests not discovering unlisted rooms
69f8f9e 
See: #72
See: #39

- You can bypass waiting for a room card to exist by passing `false` to
  the findRoomCard method on workspace

We think that it would be nice to make the `findRoomCard` function to
return the roomCard itself, or return a false; and move the wait out of
it completely; which would push responsibility for knowing whether we
should "wait for it" to the step.

This would also allow us to "check" the value of the roomCard in steps.

- We use `cucumber-pretty` to format our output legibly
zspencer added a commit that referenced this issue Aug 23, 2020
@zspencer @user512
@cjoulain @KellyAH
Wire in scenarios for guests not discovering unlisted rooms
6fe63de 
See: #72
See: #39

- You can bypass waiting for a room card to exist by passing `false` to
  the findRoomCard method on workspace

We think that it would be nice to make the `findRoomCard` function to
return the roomCard itself, or return a false; and move the wait out of
it completely; which would push responsibility for knowing whether we
should "wait for it" to the step.

This would also allow us to "check" the value of the roomCard in steps.

- We use `cucumber-pretty` to format our output legibly

Co-authored-by: Tom Lee <user512@users.noreply.github.com>
Co-authored-by: CJ Joulain <joulain@gmail.com>
Co-authored-by: KellyAH <KellyAH@users.noreply.github.com>
@zspencer zspencer mentioned this issue Aug 23, 2020
Merged
user512 added a commit that referenced this issue Aug 23, 2020
@zspencer @user512
@cjoulain @KellyAH
Wire in scenarios for guests not discovering unlisted rooms (#106)
1e34814 
See: #72
See: #39

- You can bypass waiting for a room card to exist by passing `false` to
  the findRoomCard method on workspace

We think that it would be nice to make the `findRoomCard` function to
return the roomCard itself, or return a false; and move the wait out of
it completely; which would push responsibility for knowing whether we
should "wait for it" to the step.

This would also allow us to "check" the value of the roomCard in steps.

- We use `cucumber-pretty` to format our output legibly

Co-authored-by: Tom Lee <user512@users.noreply.github.com>
Co-authored-by: CJ Joulain <joulain@gmail.com>
Co-authored-by: KellyAH <KellyAH@users.noreply.github.com>
@zspencer
Copy link
Member

Now that we have tests in place, and notes in the CHANGELOG I am going to say this is good to go.

@zspencer zspencer mentioned this issue Dec 13, 2020
Closed
7 tasks
@zspencer zspencer removed this from the 1.0 - Andromeda milestone May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
⛰️ epic Work we expect will take multiple patches to complete ✨ feature Reduces Client's Burden or Grants them Benefits
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zspencer @user512