Skip to content
This repository has been archived by the owner on Dec 5, 2022. It is now read-only.

Use the node v8 promisify API to remove unnecessary code #174

Merged
merged 11 commits into from
Sep 4, 2017
Merged

Use the node v8 promisify API to remove unnecessary code #174

merged 11 commits into from
Sep 4, 2017

Conversation

addityasingh
Copy link
Contributor

@vigneshshanmugam
Copy link
Collaborator

@addityasingh This one looks good. can you also add tests for fetch-template? You had a PR with tests and removed it at some point. remember?

@addityasingh
Copy link
Contributor Author

addityasingh commented Sep 3, 2017 •
edited
Loading

@vigneshshanmugam I created a separate PR for it earlier and it was already merged. See #161

@addityasingh
Copy link
Contributor Author

👍

vigneshshanmugam
vigneshshanmugam reviewed Sep 4, 2017
View reviewed changes
package.json
@@ -34,7 +34,8 @@
"license": "MIT",
"dependencies": {
"http-link-header": "^0.8.0",
"parse5": "^3.0.2"
"parse5": "^3.0.2",
"util.promisify": "^1.0.0"
Copy link
Collaborator

@vigneshshanmugam vigneshshanmugam Sep 4, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops what about changes on yarn.lock? can you generate it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@codecov
Copy link

codecov bot commented Sep 4, 2017 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@7d0fff2). Click here to learn what that means.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #174   +/-   ##
=========================================
  Coverage          ?   96.28%           
=========================================
  Files             ?       13           
  Lines             ?      539           
  Branches          ?       93           
=========================================
  Hits              ?      519           
  Misses            ?       20           
  Partials          ?        0
Impacted Files Coverage Δ
lib/fetch-template.js 93.47% <75%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d0fff2...a85b418. Read the comment docs.

@addityasingh
Copy link
Contributor Author

addityasingh commented Sep 4, 2017 •
edited
Loading

👍

1 similar comment
@vigneshshanmugam
Copy link
Collaborator

👍

@vigneshshanmugam vigneshshanmugam merged commit 4d8d830 into zalando:master Sep 4, 2017
@vigneshshanmugam vigneshshanmugam mentioned this pull request Sep 4, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vigneshshanmugam vigneshshanmugam vigneshshanmugam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use the node v8 promisify API to remove unnecessary code
2 participants
@addityasingh @vigneshshanmugam