Skip to content
This repository has been archived by the owner on Dec 5, 2022. It is now read-only.

do something to make the tests look better #150

Closed
vigneshshanmugam opened this issue Jun 1, 2017 · 0 comments · Fixed by #152
Closed

do something to make the tests look better #150

vigneshshanmugam opened this issue Jun 1, 2017 · 0 comments · Fixed by #152
Labels
good first bug help wanted

Comments

@vigneshshanmugam
Copy link
Collaborator

https://github.com/zalando/tailor/blob/master/tests/tailor.js - this file has been growing with every new feature and its kind of hard to go through the test case if one fails. We can do few things here

  • Reduce the test cases and keep it simple
  • Lots of repetition across the code, need to fix - Write a small helper
@addityasingh addityasingh mentioned this issue Jun 5, 2017
Merged
3 tasks
vigneshshanmugam pushed a commit that referenced this issue Jun 6, 2017
@addityasingh @vigneshshanmugam
Group the tests by features, refactor tailor instance creation i… (#152)
bd50d3d 
* #150 Group the tests by features, refactor tailor instance creation into function

* #150 Remove duplicate test and suites
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first bug help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#150 Group the tests by features, refactor tailor instance creation i…
1 participant
@vigneshshanmugam