This repository has been archived by the owner on Dec 5, 2022. It is now read-only.
#150 Group the tests by features, refactor tailor instance creation i… #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/tailor.js
Outdated
| .get('/1').reply(200, 'hello', { | ||
| 'Link': '<http://link>; rel="stylesheet",<http://link>; rel="fragment-script"' | ||
| }); | ||
| describe('Headers::Tailor', () => { |
There was a problem hiding this comment.
Already exists before.
|
Awesome work :) Thanks for taking this up. |
Codecov Report
@@ Coverage Diff @@
## master #152 +/- ##
=======================================
Coverage 91.76% 91.76%
=======================================
Files 13 13
Lines 522 522
Branches 89 89
=======================================
Hits 479 479
Misses 43 43Continue to review full report at Codecov.
|
vigneshshanmugam
approved these changes
Jun 6, 2017
rikkert
added a commit
to rikkert/tailor
that referenced
this pull request
Jun 14, 2017
* upstream/master: change the hooks logic for fragment Fix hooks Add unit test for fetch template.js (zalando#161) fix saucelabs key Update Buffer to use Node v8 syntax (zalando#154) Group the tests by features, refactor tailor instance creation i… (zalando#152) fix integration test and remove duplication (zalando#151) Provide options to parse multiple Header Links: maxAssetsLinks (zalando#140)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jscpd -f "tests/*.js" -e "**/node_modules/**"to find and removeduplicates)