Skip to content
This repository was archived by the owner on Dec 5, 2022. It is now read-only.

fix deprecation warnings in Node 8 #149

Closed
2 tasks
vigneshshanmugam opened this issue Jun 1, 2017 · 2 comments · Fixed by #154
Closed
2 tasks

fix deprecation warnings in Node 8 #149

vigneshshanmugam opened this issue Jun 1, 2017 · 2 comments · Fixed by #154

Comments

@vigneshshanmugam
Copy link
Collaborator

vigneshshanmugam commented Jun 1, 2017

Node 8 provides deprecation warnings when running with --pending-deprecation flag and we need small fixes in tailor core.

@addityasingh
Copy link
Contributor

@vigneshshanmugam IMO we should use Buffer.allocUnsafe() instead of Buffer.alloc() to gain some performance in memory allocation. Ideally, we can create some benchmark tests to compare these 2, but I think Tailor doesn't have scenarios where memory leak can happen because of Buffer.allocUnsafe()`. Thoughts?

@vigneshshanmugam
Copy link
Collaborator Author

vigneshshanmugam commented Jun 6, 2017

Yup, allowUnsafe should be the right way. Updated the list.

Memory leak can happen in tailor due to number of subscribers to tailor's event emitters. This might be a hint.

vigneshshanmugam pushed a commit that referenced this issue Jun 6, 2017
* #149 Update Buffer to use Node v8 syntax
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants