Skip to content
This repository has been archived by the owner on Dec 5, 2022. It is now read-only.

Use the node v8 promisify API to remove unnecessary code #157

Closed
wants to merge 7 commits into from
Closed

Use the node v8 promisify API to remove unnecessary code #157

wants to merge 7 commits into from

Conversation

addityasingh
Copy link
Contributor

Copy link
Collaborator

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove package-lock.json file

@addityasingh
Copy link
Contributor Author

This is auto-generated by npm 5 to optimise the install time

@vigneshshanmugam
Copy link
Collaborator

I am aware of that, But we already use yarn.lock for determinism.

@codecov-io
Copy link

codecov-io commented Jun 7, 2017

Codecov Report

Merging #157 into master will increase coverage by 4.78%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #157      +/-   ##
==========================================
+ Coverage   91.77%   96.55%   +4.78%     
==========================================
  Files          13       13              
  Lines         523      523              
  Branches       90       90              
==========================================
+ Hits          480      505      +25     
+ Misses         43       18      -25
Impacted Files Coverage Δ
lib/fetch-template.js 97.22% <0%> (+69.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7f3b06...80f2571. Read the comment docs.

@addityasingh
Copy link
Contributor Author

Closing this for now, since there are some possible performance issue with the util.promisify library

@addityasingh
Copy link
Contributor Author

Seems like wrong PR to me. I will close this and create a new 1

@vigneshshanmugam
Copy link
Collaborator

The title seems wrong here. But we need tests for fetch-templates as well :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the node v8 promisify API to remove unnecessary code
3 participants