-
Notifications
You must be signed in to change notification settings - Fork 141
Use the node v8 promisify API to remove unnecessary code #157
Conversation
* #149 Update Buffer to use Node v8 syntax
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove package-lock.json file
This is auto-generated by |
I am aware of that, But we already use |
Codecov Report
@@ Coverage Diff @@
## master #157 +/- ##
==========================================
+ Coverage 91.77% 96.55% +4.78%
==========================================
Files 13 13
Lines 523 523
Branches 90 90
==========================================
+ Hits 480 505 +25
+ Misses 43 18 -25
Continue to review full report at Codecov.
|
Closing this for now, since there are some possible performance issue with the |
Seems like wrong PR to me. I will close this and create a new 1 |
The title seems wrong here. But we need tests for fetch-templates as well :) |
promisify
API to remove unnecessary code