feat(workspaces): nested workspaces

[Anber]

motivation
yarn finds the closest manifest with workspaces. It's ok in almost all cases, but it fails if a package in workspace already has his own workspaces. In this case will be better to use global workspaces settings.

Test plan

Package
|-- package.json # has workspaces
|-- packages
|   |-- a
|   |   |-- package.json # also has workspaces
|   |   |-- more_packages
|   |   |   |-- aa # `yarn workspaces info` here should return workspaces from the root package.json
|   |   |   |-- ab
|   |-- b
…

[arcanis]

Thanks for your contribution! Nested workspaces are currently missing by design. If you want to add them, we'll need a more formal process where we expect you to detail the benefits and possible issues, and your PR will have to be thoroughly tested 🙂

[Anber]

Hi @arcanis!
I thought it's just a bug :)
Shall I open an issue for discussion or we can continue here?

[Gudahtt]

Substantial feature requests should be proposed as an RFC, which you can do here: https://github.com/yarnpkg/rfcs

Workspaces were the subject of many RFCs already. First it was proposed here, then it was split into three RFCs [1, 2, 3].

I can't find any detailed discussions about nested workspaces though. It would be great to see an RFC for that.

[milesj]

I'm curious what use case you have for such an architecture?

[Gudahtt]

The "extension repo" example from this issue comes to mind. Nested workspaces would make extending a monorepo easier to accomplish.

[milesj]

@Gudahtt Multiple workspaces at the same folder level is quite different than nested workspaces.

[Gudahtt]

Where are you seeing multiple workspaces at the same level?

The case I linked to was two monorepos, where one depends upon (i.e. is an extension of) the other. Each of these monorepos would have multiple workspaces.

e.g.

Extension Monorepo (root workspace)
  - packages/
  - Base Monorepo (root workspace)
    - packages/

Or...

Example Project (root workspace)
  - Base Monorepo (root workspace)
    - packages/
  - Extension monorepo
    - packages/

The main point here being that if you wanted this "Base Monorepo" to be usable with Yarn workspaces independently, nested workspaces would be a reasonable solution.

[Anber]

@milesj We have some projects with workspaces and one project with e2e tests which depends from all other.

[vitorcamachoo]

Any new ? I'm waiting for this feature. It will be very useful

[Anber]

@vitorcamachoo nested workspaces will be implemented in yarn v2 (#6953)

[vitorcamachoo]

What would be the behaviour of this feature ?
Im asking this because if I have the following structure:

Main Project (root workspace)
    - package.json (workspace: [web-modules, shared-modules])
  - web-modules (root workspace)
    - package.json (workspace: [*])
    - packages/*
  - shared-modules (root workspace)
    - package.json (workspace: [*])
    - packages/*

Every workspace is composed by linters, jest and so on.
So my question is, having this "nested workspaces" feature ready, running yarn on the Main project, will it install all dependencies of Main Project as well as sub workspaces (jest and linter dependencies) ?

Note:
-Every sub workspace is a git repository added by git submodule feature, because it will be used in other projects.

[arcanis]

The workspace implementation for the v2 is described here:
https://yarnpkg.github.io/berry/features/workspaces

[vitorcamachoo]

The workspace implementation for the v2 is described here:
https://yarnpkg.github.io/berry/features/workspaces

It doesn't explain in detail what it does. I have some suggestions to make:

1. Why you define on root workspace workspaces: [sub-workspace/*] if we can define without * ( workspaces: [sub-workspace]) and let the engine read the workspace attribute on sub-workspace package.json and use it to install their dependencies ?
2. Dependencies and Dev-dependencies on sub-workspace package.json, should be installed on sub-workspace level, because most of them will be tool dependencies.

[Oba-One]

Any update?

[forgetso]

Are nested workspaces supported yet? I have wasted many hours on this and I can't find any clear documentation surrounding it.

[cimchd]

Are nested workspaces supported yet? I have wasted many hours on this and I can't find any clear documentation surrounding it.

Almost. We have a project structure like above:

Main Project (root workspace)
    - .yarn/
    - package.json (workspace: [web-modules, shared-modules])
    - .yarnrc.yml
    - yarn.lock
  - web-modules (root workspace)
    - package.json (workspace: [*])
    - packages/*
  - shared-modules (root workspace)
    - package.json (workspace: [*])
    - packages/*

and it is working. :-)
The only problem we have, is that it's only working without nested .yarn 3 folders. So if we install yarn 3 separately inside the workspaces we encounter several problems.
Not working:

    - .yarn/
    - package.json (workspace: [web-modules, shared-modules])
    - .yarnrc.yml
    - yarn.lock
  - web-modules (root workspace)
    - .yarn/
    - package.json (workspace: [*])
    - packages/*
    - .yarnrc.yml
  - shared-modules (root workspace)
    - .yarn/
    - package.json (workspace: [*])
    - packages/*
    - .yarnrc.yml
    - yarn.lock

It's only working if there is only one .yarn folder inside the root folder.

[forgetso]

It's only working if there is only one .yarn folder inside the root folder.

Thanks, @cimchd. This helped me so much.